https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-787 DRP 2-D Pipeline <p>With</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /projects/HSC/PFS/Subaru/CALIB-SuNSS/DETECTORMAP/pfsDetectorMap-046270-b1.fits</pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-python"> detMap.findFiberId(geom.PointD(6000, -20000)) </pre> </div></div> <p>crashes python in our C++:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> python3.7: src/ModelBasedDetectorMap.cc:177: virtual <span class="code-object">int</span> pfs::drp::stella::ModelBasedDetectorMap::findFiberId(<span class="code-keyword">const</span> PointD&amp;) <span class="code-keyword">const</span>: Assertion `xNew &gt; xLow &amp;&amp; xNew &lt; xHigh' failed. Caught signal 6, backtrace follows: /tigress/HSC/PFS/stack/current/stack/current/Linux64/utils/18.1.0/lib/libutils.so(+0x14a74) [0x2ba2eee49a74] /lib64/libc.so.6(+0x36450) [0x2ba2dcf53450] /lib64/libc.so.6(gsignal+0x37) [0x2ba2dcf533d7] /lib64/libc.so.6(abort+0x148) [0x2ba2dcf54ac8] /lib64/libc.so.6(+0x2f1a6) [0x2ba2dcf4c1a6] /lib64/libc.so.6(+0x2f252) [0x2ba2dcf4c252] /home/rhl/PFS/drp/stella/lib/libdrp_stella.so(pfs::drp::stella::ModelBasedDetectorMap::findFiberId(lsst::geom::Point&lt;<span class="code-object">double</span>, 2&gt; <span class="code-keyword">const</span>&amp;) <span class="code-keyword">const</span>+0x25f) [0x2ba33ba7bb0f] </pre> </div></div> PIPE2D-787

Invalid points can crash the DetectorMap code

Story Normal Done Done price rhl Wed, 17 Mar 2021 15:37:44 +0000 Wed, 17 Mar 2021 19:40:49 +0000 Wed, 17 Mar 2021 19:40:49 +0000 0 3 <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> #0 0x00002aaaaaf213d7 in raise () from /lib64/libc.so.6 #1 0x00002aaaaaf22ac8 in abort () from /lib64/libc.so.6 #2 0x00002aaaaaf1a1a6 in __assert_fail_base () from /lib64/libc.so.6 #3 0x00002aaaaaf1a252 in __assert_fail () from /lib64/libc.so.6 #4 0x00002aaafbe58807 in pfs::drp::stella::ModelBasedDetectorMap::findFiberId (point=..., <span class="code-keyword">this</span>=0x555557c78a30) at include/pfs/drp/stella/DetectorMap.h:33 #5 pfs::drp::stella::ModelBasedDetectorMap::findFiberId (<span class="code-keyword">this</span>=0x555557c78a30, point=...) at src/ModelBasedDetectorMap.cc:156 #6 0x00002aab0d559be3 in pybind11::cpp_function::cpp_function&lt;<span class="code-object">int</span>, pfs::drp::stella::DifferentialDetectorMap, lsst::geom::Point&lt;<span class="code-object">double</span>, 2&gt; <span class="code-keyword">const</span>&amp;, pybind11::name, pybind11::is_method, pybind11::sibling, pybind11::arg&gt;(<span class="code-object">int</span> (pfs::drp::stella::DifferentialDetectorMap::*)(lsst::geom::Point&lt;<span class="code-object">double</span>, 2&gt; <span class="code-keyword">const</span>&amp;) <span class="code-keyword">const</span>, pybind11::name <span class="code-keyword">const</span>&amp;, pybind11::is_method <span class="code-keyword">const</span>&amp;, pybind11::sibling <span class="code-keyword">const</span>&amp;, pybind11::arg <span class="code-keyword">const</span>&amp;)::{lambda(pfs::drp::stella::DifferentialDetectorMap <span class="code-keyword">const</span>*, lsst::geom::Point&lt;<span class="code-object">double</span>, 2&gt; <span class="code-keyword">const</span>&amp;)#1}::<span class="code-keyword">operator</span>()(pfs::drp::stella::DifferentialDetectorMap <span class="code-keyword">const</span>*, lsst::geom::Point&lt;<span class="code-object">double</span>, 2&gt; <span class="code-keyword">const</span>&amp;) <span class="code-keyword">const</span> ( <span class="code-keyword">this</span>=&lt;optimized out&gt;, <span class="code-keyword">this</span>=&lt;optimized out&gt;, args#0=..., c=&lt;optimized out&gt;) at /projects/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/pybind11/2.2.4.lsst1+2/include/pybind11/<span class="code-keyword">cast</span>.h:491 </pre> </div></div> <p>Fixed:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (lsst-scipipe) pprice@tiger2-sumire:~ $ python -c <span class="code-quote">'from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap; from lsst.geom <span class="code-keyword">import</span> Point2D; detMap = DetectorMap.readFits(<span class="code-quote">"/projects/HSC/PFS/Subaru/CALIB-SuNSS/DETECTORMAP/pfsDetectorMap-046270-b1.fits"</span>); detMap.findFiberId(Point2D(6000, -20000))'</span> Traceback (most recent call last): File <span class="code-quote">"&lt;string&gt;"</span>, line 1, in &lt;module&gt; lsst.pex.exceptions.wrappers.OutOfRangeError: File <span class="code-quote">"src/ModelBasedDetectorMap.cc"</span>, line 159, in virtual <span class="code-object">int</span> pfs::drp::stella::ModelBasedDetectorMap::findFiberId(<span class="code-keyword">const</span> PointD&amp;) <span class="code-keyword">const</span> Point is not on the image {0} lsst::pex::exceptions::OutOfRangeError: <span class="code-quote">'Point is not on the image'</span> </pre> </div></div> <p>Review approved. Changes look fine.</p> <p>Merged.</p> Development Rank 0|zzs47y:zzzzzzzy Reviewers hassan Sprint 2DDRP-2021 A3