https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-786 DRP 2-D Pipeline <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> reports:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> detMap = DetectorMap.readFits(<span class="code-quote">"/projects/HSC/PFS/Subaru/CALIB-SuNSS/DETECTORMAP/pfsDetectorMap-046270-b1.fits"</span>) detMap.findPoint(3, 683.138) </pre> </div></div> <p>raises:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> OutOfRangeError: File <span class="code-quote">"src/GlobalDetectorModel.cc"</span>, line 209, in lsst::geom::Point2D pfs::drp::stella::GlobalDetectorModel::<span class="code-keyword">operator</span>()(<span class="code-keyword">const</span> Point2D&amp;, std::size_t, bool) <span class="code-keyword">const</span> xi,eta=(17.983522,2414.269953) fiberId,wavelength=((3, 683.138)) is out of range of Box2D(Point2D(11.3896, -2192.4), Extent2D(4079.86, 4384.8)) {0} lsst::pex::exceptions::OutOfRangeError: <span class="code-quote">'xi,eta=(17.983522,2414.269953) fiberId,wavelength=((3, 683.138)) is out of range of Box2D(Point2D(11.3896, -2192.4), Extent2D(4079.86, 4384.8))'</span> </pre> </div></div> <p>The expected result is <tt>(NaN, NaN)</tt>.</p> PIPE2D-786

DifferentialDetectorMap produces OutOfRangeError instead of NaN

Story Normal Done Done price price Wed, 17 Mar 2021 14:20:24 +0000 Wed, 17 Mar 2021 19:41:18 +0000 Wed, 17 Mar 2021 19:41:18 +0000 0 2 <p>After the fix:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &gt;&gt;&gt; from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap &gt;&gt;&gt; detMap = DetectorMap.readFits(<span class="code-quote">"/projects/HSC/PFS/Subaru/CALIB-SuNSS/DETECTORMAP/pfsDetectorMap-046270-b1.fits"</span>) &gt;&gt;&gt; detMap.findPoint(3, 683.138) Point2D(nan, nan) </pre> </div></div> <p>Changes look fine. Exceptions should be logged however. Please see pull request comments for details.</p> <p>Added a way to allow exceptions to propagate, but that is off by default.</p> <p>Merged to master.</p> Development Rank 0|zzs47y:zzzzzzzw Reviewers hassan Sprint 2DDRP-2021 A3