https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-785 DRP 2-D Pipeline <p>Looking at the discrepancies between the detectorMap and the fiberProfile centres shows that the Chebyshev fit to the x-centres is pretty good, but not perfect.  Using the detectorMap (probably with an affine distortion) would be better.  The figure <span class="image-wrap" style=""><a id="13426_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/13426/13426_quiver-46188-fiberTrace.png" title="quiver-46188-fiberTrace.png" file-preview-type="image" file-preview-id="13426" file-preview-title="quiver-46188-fiberTrace.png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/13426/_thumb_13426.png" style="border: 0px solid black" /></a></span> shows every fifth fibre, and clearly some of the fits are a bit off (much worse in the dense-pack region).  Using the black spots will help here, of course, but a global distortion would probably be better.</p> PIPE2D-785

Add option to use tweaked detectorMap to define fiberProfiles

Story Normal Done Done price rhl Tue, 16 Mar 2021 20:54:33 +0000 Fri, 26 Mar 2021 15:29:21 +0000 Fri, 26 Mar 2021 15:29:21 +0000 0 3 <p>I think the default <tt>profiles.centroidRadius=5</tt> is too large to work well in the dense fiber region. The other features look smooth, and could be fixed using a higher order polynomial (currently <tt>profiles.centerFit.order=9</tt>).</p> <p>Maybe we'd get away with that, but ignoring the detectorMap in favour of a per-fibre fit is the wrong thing to do.</p> <p>Ready for review.</p> <p>This looks fine. Minor comments in the pull request. One question: is the adjusted detectorMap persisted? I could not see that. May be useful for debugging to have that option. </p> <p>The detectorMap isn't adjusted: the trace positions are.</p> <p>I think Hassan's request is reasonable, but possibly a different ticket.  Currently only arcs can be used to adjust the positions of the traces in the DetectorMap, and this is a problem for e.g. the SuNSS blue arm where we have decent quartzes but only very sparse arcs (especially before we found out about "dome arcs").  Obviously you can only update the wavelengths directly by using the arcs, but in reality I suspect that you can do a pretty good job just off the traces (or will, once we understand the space of distortions in the cameras)</p> <p>Created <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-796" title="Allow adjustment of detectorMap in reduceExposure" class="issue-link" data-issue-key="PIPE2D-796"><del>PIPE2D-796</del></a>: Allow adjustment of detectorMap in reduceExposure.</p> <p>Merged.</p> Development Rank 0|02qpt6:508yl0chzzy000001 Reviewers hassan Sprint 2DDRP-2021 A3