<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:57:49 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-780] reduceArcs should include all the fibres in the output DetectorMap</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-780</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;When I fit a DifferentialDetectorMap in reduceArc, it only includes the detected fibres, not all of the ones in the base DetectorMap. &lt;/p&gt;

&lt;p&gt;Paul points out that this is because if a fiber doesn&apos;t have any measured lines, we can&apos;t measure a slit offset for it, and therefore we don&apos;t really know where it is. However, we should assume that slit offsets are measured once and left fixed thereafter as they are a property of the epoxy in the slit and should not change with time.  This means that something like reduceArc which updates the DetectorMap shouldn&apos;t touch them unless specially requested to do so.&lt;/p&gt;

&lt;p&gt;We do still have to measure them initially. For broken fibres the values don&apos;t matter (in the case of SuNSS the fibres are not broken in DCB data, although fiberId 3 is very faint).  For all other fibres when the spectrograph is first delivered we&apos;ll take lots of spot data, quartz, arcs, ... and turn on all the &quot;slit offset&quot; options to measure the soon-to-be-fixed values.&lt;/p&gt;</description>
                <environment></environment>
        <key id="15464">PIPE2D-780</key>
            <summary>reduceArcs should include all the fibres in the output DetectorMap</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="rhl">rhl</reporter>
                        <labels>
                    </labels>
                <created>Mon, 15 Mar 2021 13:14:25 +0000</created>
                <updated>Fri, 26 Mar 2021 17:59:10 +0000</updated>
                            <resolved>Tue, 23 Mar 2021 17:04:25 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="18953" author="price" created="Tue, 23 Mar 2021 15:12:47 +0000"  >&lt;p&gt;&lt;tt&gt;DifferentialDetectorMap&lt;/tt&gt; couldn&apos;t include all the fibers because &lt;tt&gt;GlobalDetectorModel&lt;/tt&gt;, which implemented the distortion correction, included fiber offsets as part of the model. This was left over from &lt;tt&gt;GlobalDetectorMap&lt;/tt&gt;, which we are not using any more, so I removed &lt;tt&gt;GlobalDetectorMap&lt;/tt&gt; and the fiber offsets in &lt;tt&gt;GlobalDetectorModel&lt;/tt&gt;, and made it cover all fibers. Here&apos;s a demonstration showing that fiber 3 (marked as bad in the &lt;tt&gt;pfsConfig&lt;/tt&gt;) is now present in the detectorMap:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
reduceArc.py /projects/HSC/PFS/Subaru --calib=/projects/HSC/PFS/Subaru/CALIB-SuNSS --rerun=price/pipe2d-780 --id visit=45743..45746 arm=r -c reduceExposure.isr.doFlat=False -j 5

&amp;gt;&amp;gt;&amp;gt; from pfs.drp.stella &lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; DetectorMap
&amp;gt;&amp;gt;&amp;gt; detMap = DetectorMap.readFits(&lt;span class=&quot;code-quote&quot;&gt;&quot;/projects/HSC/PFS/Subaru/rerun/price/pipe2d-780/DETECTORMAP/pfsDetectorMap-045743-r1.fits&quot;&lt;/span&gt;)
&amp;gt;&amp;gt;&amp;gt; detMap.findPoint(3, 800)
Point2D(4002.914678, 2070.318358)
&amp;gt;&amp;gt;&amp;gt; detMap.getXCenter(3)
array([4016.33286104, 4016.31589901, 4016.29895405, ..., 4019.00512576,
       4019.02311469, 4019.04113485])
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="18956" author="hassan" created="Tue, 23 Mar 2021 16:11:50 +0000"  >&lt;p&gt;All changes look fine. No additional comments.&lt;/p&gt;</comment>
                            <comment id="18958" author="price" created="Tue, 23 Mar 2021 17:04:25 +0000"  >&lt;p&gt;Merged.&lt;/p&gt;</comment>
                            <comment id="19008" author="rhl" created="Fri, 26 Mar 2021 17:14:39 +0000"  >&lt;p&gt;I think it&apos;d be helpful to mention in the closing comment when tickets required changes to pfs.datamodel or lsst.obs.pfs. &#160;Yes, I could have read the pull requests.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</comment>
                            <comment id="19010" author="hassan" created="Fri, 26 Mar 2021 17:59:10 +0000"  >&lt;p&gt;Valid point. Agreed, Robert.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpt6:508yl0chzzy000003</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="102">2DDRP-2021 A3</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>