https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-766 DRP 2-D Pipeline <p>It is not going to be correct to assume that all visits passed to reduceExposure have the pfsConfig file.  Please fix the code to handle this (the worst and simplest solution would be to check when the assumption is violated, but I think we should do better than that).</p> PIPE2D-766

reduceExposure assumes that all visits have the same pfsConfig file

Story Normal Done Done price rhl Mon, 8 Mar 2021 07:12:42 +0000 Thu, 11 Mar 2021 21:08:10 +0000 Thu, 11 Mar 2021 21:08:10 +0000 0 3 <p><tt>reduceExposure</tt> is operating over all arms from all spectrographs of a single visit. These absolutely should all have the same <tt>pfsConfig</tt>.</p> <p>You can give it a list of visits, and it helpfully processes all of them.  If this is not the intended behaviour we should discuss, and if we decide to stick with it add appropriate checks.  I'd rather fix the pfsConfig assumption.</p> <p>I don't think it's an assumption. There's only one pfsConfig for a visit, and so all arms for that visit have the same pfsConfig. The <tt>TaskRunner</tt> <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceExposure.py#L74-L82" class="external-link" rel="nofollow">ensures</a> that it receives one visit at a time. Or are you concerned about running it from a python prompt, operating on what it's given in violation of the (admittedly not crystal clear) <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceExposure.py#L152" class="external-link" rel="nofollow">docs</a>?</p> <p>This one sounds like user error that we can close as mistaken (or do we have to use "won't fix"?). Running from a notebook is my problem, although I'd probably add a check that all the data being processed is indeed from the same visit.</p> <p>Added a check that all visits are the same.</p> <p>Approved with no further changes requested.</p> <p>Merged to master.</p> Development Rank 0|zzs47y:zzzzz Reviewers hassan Sprint 2DDRP-2021 A3