https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-739 DRP 2-D Pipeline <p>Now that pfsArms have broken fibres (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-720" title="Include broken fibres in pfsArm/pfsMerged files" class="issue-link" data-issue-key="PIPE2D-720"><del>PIPE2D-720</del></a>), the assumption in mergeLsfs that assumes that all fiberIds are in warpLsf is invalid.<br/> It is not obvious that the obvious fix of checking for the presence of the fibre is correct, or whether the problem should be pushed upstream. It's also not possible to check that the problem is indeed a broken fibre as pfsConfig isn't available</p> PIPE2D-739

mergeArms doesn't handle broken fibres in mergeLsfs

Story Normal Done Done rhl rhl SuNSS Wed, 24 Feb 2021 21:43:21 +0000 Sat, 27 Feb 2021 03:21:58 +0000 Sat, 27 Feb 2021 03:21:58 +0000 0 2 <p>The quick fix is</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">for</span> ii in range(len(spectra)): ff = spectra.fiberId[ii] warpedLsf[ff] = warpLsf(lsf[ff], spectra.wavelength[ii], wavelength) <span class="code-keyword">if</span> ff in lsf <span class="code-keyword">else</span> None </pre> </div></div> <p>Actually, let's get the hack merged and then think about doing this properly later</p> <p>PR <a href="https://github.com/Subaru-PFS/drp_stella/pull/152" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_stella/pull/152</a></p> <p>Approved by me, but may need a check by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>.</p> <p>Review complete to move this fix promptly to master.</p> Development Rank 0|02qpt6:508yl0chzzy00000c Reviewers price Sprint 2DDRP-2021 A 2