PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 [PIPE2D-734] Handle broken red shutter in ISR https://pfspipe.ipmu.jp/jira/browse/PIPE2D-734 DRP 2-D Pipeline <p>The red shutter on SM1 is currently broken, significantly reducing our ability to correctly process data. Please add a work-around.</p> PIPE2D-734 Handle broken red shutter in ISR Story Normal Done Done rhl rhl Sun, 21 Feb 2021 15:50:25 +0000 Sun, 28 Feb 2021 16:06:15 +0000 Sun, 28 Feb 2021 16:06:15 +0000 0 2 <p>The initial implementation assumes that each science exposure is followed by a bias. If this is too burdensome it should be possible to construct the correction from the science frame, but this requires a better model of the readout (in particular the wipe sequence) than we currently have. This would have better noise properties, but would also be more sensitive to temporal variation of the incident light.</p> <p>I've now implemented the "analytic" version (<tt>isr.doBrokenRedShutter=True isr.brokenRedShutter.useAnalytic=True</tt>). This is necessary when we don't take enough biases and the illumination is changing &#8212; if it's different between the science integration and the readout we don't have enough information to make the corrections.</p> <p>N.b. the correction is in the ISR, but it should be after CR repair.</p> <p>For running <tt>constructFiberProfiles.py</tt> on SuNSS data, I think you want to use <tt>profiles.centroidRadius=3 profiles.profileRadius=3</tt>. This helps prevent bad profiles on the full-density fibers, which is what caused awful extractions.</p> <p>(Wrong ticket! This was about <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-739" title="mergeArms doesn&#39;t handle broken fibres in mergeLsfs" class="issue-link" data-issue-key="PIPE2D-739"><del>PIPE2D-739</del></a>)</p> <p><a href="https://github.com/Subaru-PFS/drp_stella/pull/153" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_stella/pull/153</a></p> <p>I'm not totally happy with this, in particular it should run the analytic version <em>after</em> repairing CRs, and that's not done in the ISR. However, I think it's good enough to merge</p> <p>Maybe I got it right this time? <a href="https://github.com/Subaru-PFS/obs_pfs/pull/90" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/obs_pfs/pull/90</a></p> <p>Addressed comments, rebased to master, and pushed</p> Development Rank 0|02qpt6:508yl0chzzy00000a Reviewers price Sprint 2DDRP-2021 A 2