<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:56:44 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-704] Header missing END card in pfsObject fits</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-704</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;Testing the new master branch `w.2021.04`, I got the following error when I read `pfsObject` by using `astropy`, which does not exist in the previous version. This seems to affect 1D DRP as well because they also use `astropy`. I could read the data themselves correctly, so we can ignore this message, but ...&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
--------------------------------------------------------------------------- OSError Traceback (most recent call last) &amp;lt;ipython-input-26-2f2f0d5421bb&amp;gt; in &amp;lt;module&amp;gt; 13 14 &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; pfsObject in pfsObjects: ---&amp;gt; 15 with fits.open(pfsObject) as hdul: 16 flx = hdul[&lt;span class=&quot;code-quote&quot;&gt;&apos;FLUX&apos;&lt;/span&gt;].data 17 &lt;span class=&quot;code-keyword&quot;&gt;var&lt;/span&gt; = hdul[&lt;span class=&quot;code-quote&quot;&gt;&apos;COVAR&apos;&lt;/span&gt;].data[0] /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/hdulist.py in fitsopen(name, mode, memmap, save_backup, cache, lazy_load_hdus, **kwargs) 149 150 &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; HDUList.fromfile(name, mode, memmap, save_backup, cache, --&amp;gt; 151 lazy_load_hdus, **kwargs) 152 153 /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/hdulist.py in fromfile(cls, fileobj, mode, memmap, save_backup, cache, lazy_load_hdus, **kwargs) 388 &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; cls._readfrom(fileobj=fileobj, mode=mode, memmap=memmap, 389 save_backup=save_backup, cache=cache, --&amp;gt; 390 lazy_load_hdus=lazy_load_hdus, **kwargs) 391 392 @classmethod /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/hdulist.py in _readfrom(cls, fileobj, data, mode, memmap, save_backup, cache, lazy_load_hdus, **kwargs) 1062 1063 # Make sure at least the PRIMARY HDU can be read -&amp;gt; 1064 read_one = hdulist._read_next_hdu() 1065 1066 # If we&lt;span class=&quot;code-quote&quot;&gt;&apos;re trying to read only and no header units were found, /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/hdulist.py in _read_next_hdu(self) 1137 fileobj.seek(offset, os.SEEK_SET) 1138 -&amp;gt; 1139 hdu = _BaseHDU.readfrom(fileobj, **kwargs) 1140 except EOFError: 1141 self._read_all = True /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/base.py in readfrom(cls, fileobj, checksum, ignore_missing_end, **kwargs) 326 hdu = cls._readfrom_internal(fileobj, checksum=checksum, 327 ignore_missing_end=ignore_missing_end, --&amp;gt; 328 **kwargs) 329 330 # If the checksum had to be checked the data may have already been read /usr/local/lib/python3.7/site-packages/astropy/io/fits/hdu/base.py in _readfrom_internal(cls, data, header, checksum, ignore_missing_end, **kwargs) 391 &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; header is None: 392 header_offset = data.tell() --&amp;gt; 393 header = Header.fromfile(data, endcard=not ignore_missing_end) 394 hdu_fileobj = data 395 data_offset = data.tell() # *after* reading the header /usr/local/lib/python3.7/site-packages/astropy/io/fits/header.py in fromfile(cls, fileobj, sep, endcard, padding) 445 446 &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; cls._from_blocks(block_iter, is_binary, sep, endcard, --&amp;gt; 447 padding)[1] 448 &lt;span class=&quot;code-keyword&quot;&gt;finally&lt;/span&gt;: 449 &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; close_file: /usr/local/lib/python3.7/site-packages/astropy/io/fits/header.py in _from_blocks(cls, block_iter, is_binary, sep, endcard, padding) 514 # TODO: Pass &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt; error to validation framework as an ERROR, 515 # rather than raising an exception --&amp;gt; 516 raise OSError(&apos;&lt;/span&gt;Header missing END card.&lt;span class=&quot;code-quote&quot;&gt;&apos;) 517 518 header_str = &apos;&lt;/span&gt;&apos;.join(read_blocks) OSError: Header missing END card.

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="15246">PIPE2D-704</key>
            <summary>Header missing END card in pfsObject fits</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10100" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="No further work should be done on this.">Won&apos;t Fix</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="2">Won&apos;t Fix</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="kiyoto.yabe">Kiyoto Yabe</reporter>
                        <labels>
                    </labels>
                <created>Wed, 27 Jan 2021 02:36:05 +0000</created>
                <updated>Wed, 27 Jan 2021 16:19:37 +0000</updated>
                            <resolved>Wed, 27 Jan 2021 04:05:37 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="18389" author="kiyoto.yabe" created="Wed, 27 Jan 2021 04:05:20 +0000"  >&lt;p&gt;Sorry, I was stupid, to say the least.&#160;I wrongly read pickle files in the same directory, so that was a natural behavior... Sorry again.&lt;/p&gt;</comment>
                            <comment id="18390" author="price" created="Wed, 27 Jan 2021 14:44:47 +0000"  >&lt;p&gt;If you use the datamodel package to read the files, this mistake should never happen, and you&apos;re saved from having to know the file formats.&lt;/p&gt;</comment>
                            <comment id="18391" author="rhl" created="Wed, 27 Jan 2021 15:04:31 +0000"  >&lt;p&gt;While I agree with Paul, I read this ticket as saying that astropy thinks that the file is invalid. &#160;That seems odd, but if it&apos;s true we need to fix it. &#160;Can &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe&quot; class=&quot;user-hover&quot; rel=&quot;kiyoto.yabe&quot;&gt;Kiyoto Yabe&lt;/a&gt;&#160;clarify?&lt;/p&gt;</comment>
                            <comment id="18392" author="price" created="Wed, 27 Jan 2021 15:41:43 +0000"  >&lt;p&gt;My reading is that astropy failed to read the file because it&apos;s actually a pickle file (containing an LSF). This is expected behaviour, and there&apos;s not a lot we can do about it until we upgrade the LSF datamodel.&lt;/p&gt;</comment>
                            <comment id="18395" author="rhl" created="Wed, 27 Jan 2021 16:19:37 +0000"  >&lt;p&gt;Got it. &#160;As you were!&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzs3ww:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>