https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-699 DRP 2-D Pipeline <p>During analysis of data with the code that keeps illumination consistent as a function of defocus (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-671" title="Analyze Subaru images and create a 2d PSF solution - same illumination at all values of defocus" class="issue-link" data-issue-key="PIPE2D-671"><del>PIPE2D-671</del></a>), some (all?) spots which have neighbors did not get properly analyzed (see Figure). </p> <p>Identify the problem, fix and rerun this part of analysis. </p> PIPE2D-699

Rerun 2d-psf analysis for spots with neighbors

Task Normal Done Done ncaplar ncaplar Tue, 19 Jan 2021 21:26:48 +0000 Mon, 8 Feb 2021 17:04:00 +0000 Mon, 25 Jan 2021 23:46:12 +0000 0 1 <p>I seem to have identified the problem. The issue was in using floats in Psf_position.fill_crop function, within Zerike_Module. The floats can not be used at slices, and the issues is resolved when using integers. I am not sure why did this work before (probably a change when updating python versions?).</p> <p>While working on this problem I have discovered that some values identifying how parameters of ``secondary images'' are connected to the primary image (i.e., the offset and the strength of the second spot present) were wrong for Argon spots. I have corrected that. </p> <p> </p> <p>I also discovered that at the subpixel level, x and y coordinates were mixed. I have fixed that for future iterations of the code.</p> Development Rank 0|zzs3sg: Story Points 2.0