https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-691 DRP 2-D Pipeline <p>I processed the weekly data with DRP version `w.2020.51` and it looks that the sky subtraction for `pfsObject` is not fixed, though `pfsMerged` looks OK. Please investigate the cause and fix it. </p> <p><span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/13307/13307_test_pfsMerged.png" style="border: 0px solid black" /></span></p> <p><span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/13338/13338_test_pfsObject.png" style="border: 0px solid black" /></span></p> PIPE2D-691

Fix sky subtraction for pfsObject

Task Normal Done Done price Kiyoto Yabe Mon, 4 Jan 2021 23:51:32 +0000 Mon, 1 Feb 2021 21:00:31 +0000 Wed, 20 Jan 2021 15:54:16 +0000 0 3 <p>I ran my fix on the integration test, and the result is below. It's a smaller number of fibers, but should be enough to demonstrate that it's fixed.</p> <p><span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/13336/13336_pipe2d-691-fixed.png" style="border: 0px solid black" /></span> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">import</span> matplotlib.pyplot as plt <span class="code-keyword">import</span> matplotlib.cm from lsst.daf.persistence <span class="code-keyword">import</span> Butler from pfs.datamodel.utils <span class="code-keyword">import</span> calculatePfsVisitHash butler = Butler(<span class="code-quote">"/scratch/pprice/pipe2d-691/INTEGRATION/rerun/integration/pipeline"</span>) visits = [24, 25] objId = [0x12, 0x37, 0x47, 0x4c, 0x5d, 0x5e, 0x69] cmap = matplotlib.cm.rainbow axes = plt.subplot() <span class="code-keyword">for</span> ii, obj in enumerate(objId): spectrum = butler.get(<span class="code-quote">"pfsObject"</span>, catId=1, tract=0, patch=<span class="code-quote">"0,0"</span>, objId=obj, nVisit=len(visits), pfsVisitHash=calculatePfsVisitHash(visits)) axes.plot(spectrum.wavelength, spectrum.flux, ls=<span class="code-quote">"-"</span>, color=cmap(ii/len(objId))) axes.set_xlim(891.5, 893.0) axes.set_ylim(-1.0e5, +1.0e5) axes.set_xlabel(<span class="code-quote">"Wavelength (nm)"</span>) axes.set_ylabel(<span class="code-quote">"Flux (nJy)"</span>) plt.show() </pre> </div></div> <p>Reviewed. Changes look OK. If you can respond to my single comment wrt the <tt>doSubtractSky1dBeforeMerge</tt> optiont removal, that would be appreciated.</p> <p>I also confirmed the fix, which looks good. Thanks.</p> <p> </p> <p><span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/13338/13338_test_pfsObject.png" style="border: 0px solid black" /></span></p> <p>Merged to master.</p> <p>Reverted the removal of the option to switch between sky subtraction before and after merging: <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> pointed out that we need this feature.</p> Blocks PIPE2D-644 Relates PIPE2D-680 Development Rank 0|02qps3:1w Reviewers hassan Sprint 2DDRP-2021 A Story Points 2.0