https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-69 DRP 2-D Pipeline <p>tests/testDrp.py fails without returning an error code. It's due to the os/x 10.11 SIP stuff RHL assumes, but the lack of an error code is a bug. Also, not sure that we should be using python unittest to test shell scripts. How does ci_hsc do this?</p> PIPE2D-69

tests/testDrp.py fails without returning an error code on os/x 10.11

Bug Major Done Done aritter aritter Thu, 18 Aug 2016 03:58:54 +0000 Tue, 13 Jun 2017 01:56:34 +0000 Tue, 13 Jun 2017 01:56:34 +0000 0 3 <p>Re RHL's question how ci_hsc does the integration test, that's way more complicated and I haven't got any comments yet from <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>. RHL said if it works leave it but ask Paul. We might possibly want to change this in the future in another ticket...</p> <p>I don't remember the context of that question, but I don't think we'd want to follow the ci_hsc approach here: it has plenty of problems of its own.</p> <p>Didn't check before what happens if there is an actual error. Turns out it would still have passed. Fixed that now...</p> <p>Stealing this review for myself too...</p> <p>I didn't run this to confirm that you do return an error code. If you did check this, good to merge after you deal with the comment.</p> <p>Merged into master</p> Blocks PIPE2D-53 Development Rank 0|ii00v2:v Reviewers swinbank Sprint 2014-16