https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-678 DRP 2-D Pipeline <p><tt>generateReductionSpec.py</tt> currently extracts reduction specs for the entire opdb. This will not scale, so we should add options to restrict the list of visits by a visit and/or date range.</p> PIPE2D-678

Add visit and date restrictions for generateReductionSpec

Story Normal Done Done sogo.mineo price Wed, 9 Dec 2020 16:35:38 +0000 Thu, 14 Jan 2021 04:37:59 +0000 Thu, 14 Jan 2021 04:37:59 +0000 0 2 <p>I wonder how to express a time span in command lines.</p> <p>First, I think that the end of a time span should be exclusive. `Sps_exposure.time_exp_start` has microsecond accuracy. If the end of a time span is inclusive, it is difficult to iterate over dates without losing unfortunate records in the gaps at midnights. I mean, if a user wants to do this:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> somecommand.py --daterange=2021-01-01T00:00:00..2021-01-01T23:59:59 somecommand.py --daterange=2021-01-02T00:00:00..2021-01-02T23:59:59 somecommand.py --daterange=2021-01-03T00:00:00..2021-01-03T23:59:59 : </pre> </div></div> <p>Then, a record at <tt>2021-01-01T23:59:59.999999</tt> will be lost. I don't know how well SQLite3 works, but I know some poor programs that occasionally output <tt>2021-01-01T23:59:60.000000</tt> by rounding <tt>2021-01-01T23:59:59.9999996</tt> (This is not related to leap seconds). So, it may be useless for the user to write </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> somecommand.py --daterange=2021-01-01T00:00:00..2021-01-01T23:59:59.999999 somecommand.py --daterange=2021-01-02T00:00:00..2021-01-02T23:59:59.999999 somecommand.py --daterange=2021-01-03T00:00:00..2021-01-03T23:59:59.999999 : </pre> </div></div> <p>because these commands still cannot catch <tt>2021-01-01T23:59:60.000000</tt>. The user cannot simply say <tt>2021-01-01T23:59:60</tt> because python's <tt>datetime.datetime</tt> does not permit 60 for the second.</p> <p>Second, if I make the end of a time span exclusive, then it is confusing to keep using <tt>..</tt>. Should I use '/' as in <a href="https://en.wikipedia.org/wiki/ISO_8601" class="external-link" rel="nofollow">https://en.wikipedia.org/wiki/ISO_8601</a> ?</p> <p>What about having separate <tt>&#45;&#45;begin</tt> and <tt>&#45;&#45;end</tt> arguments? Both could default to unset, specifying an open range.</p> <p>I added <tt>-<del>visit-start</tt>, <tt></del><del>visit-end</tt>, <tt></del><del>date-start</tt>, and <tt></del>-date-end</tt>. Could you review the change?</p> <p>Very nice work, thanks!</p> <p>Merged to master. Thank you.</p> Relates PIPE2D-423 Development Rank 0|zzs2rz:zk Reviewers price Sprint 2DDRP-2021 A