https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-665 DRP 2-D Pipeline <p>The current code to generate sky1d uses linear interpolation. We need to do better.</p> <p>Because of dithering of wavelengths relative to the pixel grid we should not have problems with under sampling. A least-squares spline might be a way to get something running quickly</p> PIPE2D-665

Use better interpolation in generating sky1D

Story Normal Done Done price rhl Fri, 4 Dec 2020 16:41:24 +0000 Tue, 31 Aug 2021 15:55:24 +0000 Tue, 31 Aug 2021 15:55:24 +0000 0 3 <p>After merging <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-680" title="Add a config to change the order of merging and 1-D sky subtraction" class="issue-link" data-issue-key="PIPE2D-680"><del>PIPE2D-680</del></a> this is less critical as fixing <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-666" title="Improve interpolation used to generate pfsMerged" class="issue-link" data-issue-key="PIPE2D-666">PIPE2D-666</a> will automatically improve the sky1D sampling when <tt>doSubtractSky1dBeforeMerge</tt> is <tt>True</tt>.</p> <p>This ticket still needs to be done, as it allows us to handle under-sampling using dithers.</p> <p>This includes some work to refactor <tt>FitFocalPlaneTask</tt> and <tt>FocalPlaneFunction</tt> to make it easier to use and to extend (see also <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-663" title="Reconsider the API for pfs.drp.stella.fitFocalPlane.FocalPlaneFunction" class="issue-link" data-issue-key="PIPE2D-663"><del>PIPE2D-663</del></a>), and porting of <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a>'s oversampled spline (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-821" title="Add RHL&#39;s block+LSQ spline algorithm" class="issue-link" data-issue-key="PIPE2D-821"><del>PIPE2D-821</del></a>).</p> <p>In general looks fine. Minor comments added.</p> <p>Addressed comments and merged.</p> Relates PIPE2D-821 Development Rank 0|zzs89z:s Reviewers hassan Sprint 2DDRP-2021 A 8