https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-663 DRP 2-D Pipeline <p>In order to return a sky spectrum for fiberId <tt>fid</tt> the current code looks like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pfsSky1D = butler.get(<span class="code-quote">'sky1d'</span>, dataId) sky = pfsSky1D([wavelength], pfsConfig.extractCenters([fid])[0] </pre> </div></div> <p>The sky spectrum for a given fibre depends on the fibre as well as the position in the focal plane, so I think that we probably want an API more like</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pfsSky1D(pfsConfig, [wavelength], [fid]) </pre> </div></div> <p>An additional semi-trivial point is that it's a little awkward to specify arrays of wavelengths and fiberIds when I want the sky spectrum for a single object. It might be worth adding some syntactic sugar.</p> PIPE2D-663

Reconsider the API for pfs.drp.stella.fitFocalPlane.FocalPlaneFunction

Story Normal Done Done price rhl Fri, 4 Dec 2020 15:18:31 +0000 Fri, 28 Jan 2022 17:16:25 +0000 Tue, 31 Aug 2021 15:55:48 +0000 0 2 <p>Less important once I discovered that we have <tt>pfsMerged.sky</tt></p> <p>I revised the <tt>FocalPlaneFunction</tt> API as part of <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-665" title="Use better interpolation in generating sky1D" class="issue-link" data-issue-key="PIPE2D-665"><del>PIPE2D-665</del></a>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-665" title="Use better interpolation in generating sky1D" class="issue-link" data-issue-key="PIPE2D-665"><del>PIPE2D-665</del></a> merged.</p> Development Rank 0|02qpq3:r18 Sprint 2DDRP-2021 A 2