https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-635 DRP 2-D Pipeline <p>The implementation of <tt>FitFocalPlaneTask</tt> is currently a placeholder, and its shortcomings are starting to be felt. Upgrade its capabilities, so that it implements rejection and handles errors (input and output). Check that this solves the problems from <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE1D-14" title="Run 1D-DRP for the resulting products from 2D in the end-to-end processing test" class="issue-link" data-issue-key="PIPE1D-14"><del>PIPE1D-14</del></a>/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-633" title="Debug false lines in extracted spectra" class="issue-link" data-issue-key="PIPE2D-633"><del>PIPE2D-633</del></a>.</p> <p>One thing that may be required is to increase the number of sky fibers in the integration test (e.g., science/sky/fluxstd from 7/2/1 to 4/5/1 or 8/5/2). If modifying the pfsDesign files, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> has particular science objIds that I should be sure to include (e.g., <tt>0x37</tt>).</p> PIPE2D-635

Improve FitFocalPlaneTask

Story Normal Done Done price price Tue, 29 Sep 2020 00:29:23 +0000 Mon, 4 Jan 2021 20:23:21 +0000 Wed, 21 Oct 2020 15:35:12 +0000 0 2 <p>I'm happy if you include objId = 0x12, 0x37, 0x69, and 0x1 (fluxstd).</p> <p>Upgraded the <tt>FitFocalPlaneTask</tt> and expanded the number of fibers in the integration test. Discovered that the simulator isn't including the gain, so fixed that at the same time, to avoid multiple quick updates to the integration test dataset.</p> <p>Thank you for this implementation. I did checkout the branch and run the process, and I no longer see the feature at ~633 nm. The redshift determination by DRP1D seems to be reasonable as well. Great!</p> <p>Merged to master.</p> Relates PIPE2D-633 PIPE1D-14 Development Rank 0|02qps2:o Reviewers hassan Sprint 2DDRP-2021 A Story Points 4.0