https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-611 DRP 2-D Pipeline <p>As discussed on telecons June 19 and June 22, `reduceArc` function that modifies DetectorMap at the moment only `fixes` the DetectorMap in the wavelength direction (y-direction), but it does not modify the DetectorMap in the x-direction (perpendicular to the wavelength direction). This causes 2D PSF subtractions to be very poor and it is not possible to analyze the quality of the subtraction. </p> <p>(I have left story points empty as I have no good idea of the scope of this work)</p> PIPE2D-611

reduceArc should also fix the x-direction of the DetectorMap

Task Normal Done Done price ncaplar Mon, 22 Jun 2020 23:57:22 +0000 Mon, 4 Jan 2021 20:22:56 +0000 Sun, 28 Jun 2020 16:04:01 +0000 0 2 <p><tt>reduceArc.py</tt> already has a <tt>doUpdateCenters</tt> config parameter, but it uses the fiberTrace! I'll add something to tweak it using the arc lines also.</p> <p>Choosing which feature to use should be left to the user, as the software can't know whether the user will prefer the centers from the arc or the quartz.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ generateCommands.py /projects/HSC/PFS/LAM/ --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --blocks=pipe2d_611 -j 10 pipe2d-611.yaml calibs.sh --devel --force (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ detrend.py /projects/HSC/PFS/LAM --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --id visit=21515 arm=r --no-versions (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ bootstrapDetectorMap.py /projects/HSC/PFS/LAM --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --flatId visit=21122 arm=r --arcId visit=21515 arm=r bootstrap INFO: Matched 370 lines bootstrap INFO: Median difference from detectorMap: -9.974619,-5.693824 pixels bootstrap INFO: Fit 193/228 points, rms: x=0.043026 y=0.119466 total=0.088148 pixels bootstrap INFO: Updating detectorMap... bootstrap INFO: Median difference from detectorMap: -10.189670,-5.453311 pixels bootstrap INFO: Fit 120/142 points, rms: x=0.101351 y=0.097857 total=0.085120 pixels bootstrap INFO: Updating detectorMap... (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ cp /projects/HSC/PFS/LAM/rerun/price/pipe2d-611/DETECTORMAP/pfsDetectorMap-021515-r1.fits /projects/HSC/PFS/LAM/CALIB-price/DETECTORMAP/pfsDetectorMap-000000-r1.fits Looks pretty good! We're going to have to introduce an artificial shift, to demonstrate we can undo it... &gt;&gt;&gt; <span class="code-keyword">import</span> astropy.io.fits &gt;&gt;&gt; ff = astropy.io.fits.open(<span class="code-quote">"/projects/HSC/PFS/LAM/CALIB-price/DETECTORMAP/pfsDetectorMap-000000-r1.fits"</span>) &gt;&gt;&gt; ff[3].header[<span class="code-quote">"EXTNAME"</span>] <span class="code-quote">'CENTER'</span> &gt;&gt;&gt; ff[3].data.value += 1.0 &gt;&gt;&gt; ff.writeto(<span class="code-quote">"/projects/HSC/PFS/LAM/CALIB-price/DETECTORMAP/pfsDetectorMap-000000-r1.fits"</span>, clobber=True) (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ displayDetectorMap.py /projects/HSC/PFS/LAM --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --id visit=21515 arm=r --no-versions (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ reduceArc.py /projects/HSC/PFS/LAM --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --id visit=21515 arm=r --no-versions reduceArc INFO: Tweaking fiber 650 xCenter by -1.232491 (+/- 0.049559) reduceArc INFO: Tweaking fiber 587 xCenter by -1.166069 (+/- 0.029186) reduceArc INFO: Tweaking fiber 525 xCenter by -1.219642 (+/- 0.038179) reduceArc INFO: Tweaking fiber 464 xCenter by -1.191371 (+/- 0.045484) reduceArc INFO: Tweaking fiber 401 xCenter by -1.206986 (+/- 0.057679) reduceArc INFO: Tweaking fiber 339 xCenter by -1.186496 (+/- 0.110483) reduceArc INFO: Tweaking fiber 255 xCenter by -1.190592 (+/- 0.118263) reduceArc INFO: Tweaking fiber 192 xCenter by -1.098192 (+/- 0.114480) reduceArc INFO: Tweaking fiber 63 xCenter by -1.195772 (+/- 0.094612) reduceArc INFO: Tweaking fiber 2 xCenter by -1.110896 (+/- 0.140032) (lsst-scipipe) pprice@tiger2-sumire:/tigress/pprice/pipe2d-611 $ displayDetectorMap.py /projects/HSC/PFS/LAM --calib /projects/HSC/PFS/LAM/CALIB-price --rerun price/pipe2d-611 --id visit=21515 arm=r --no-versions -c frame=2 </pre> </div></div> <p>Looks good!</p> <p>The arc-based tweak works, as demonstrated in the attached figures.</p> <p>Before tweak (with an artificial 1 pixel offset):<br/> <span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/12710/12710_before.png" style="border: 0px solid black" /></span></p> <p>After tweak:<br/> <span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/12709/12709_after.png" style="border: 0px solid black" /></span></p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=ncaplar" class="user-hover" rel="ncaplar">ncaplar</a>: note the addition of a new script, <tt>displayDetectorMap.py</tt>, which I hope will make it easier to see the quality of the detectorMaps relative to the arcs. See the above log for details on how to use it.</p> <p>Ok. Looking forward to it. This is tested on simulation and not on the real data, right?</p> <p> </p> <p>The above is LAM data.</p> <p>Merged to master yesterday, while Jira was down.</p> Blocks PIPE2D-490 Development Rank 0|02qps2:i Reviewers hassan Sprint 2DDRP-2021 A