https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-609 DRP 2-D Pipeline <p>In the process of using <tt>generateCommands.py</tt>, I've noticed some behaviours which deserve addressing:</p> <ul> <li>I can't specify multiple types via <tt>&#45;&#45;calibTypes</tt>.</li> <li>If the particular calib has already been ingested, the generated script fails (<tt>RuntimeError: File ... already exists; consider --config clobber=True</tt>) despite <tt>&#45;&#45;force</tt>, and I'm unaware of any means of setting <tt>clobber=True</tt> in the ingestion.</li> <li>If I have a local subdirectory <tt>CALIB</tt>, running <tt>generateCommands.py /path/to/DATA/ --calib CALIB ...</tt> sets the calibration directory to <tt>/path/to/DATA/CALIB</tt> rather than <tt>CALIB</tt>.</li> </ul> PIPE2D-609

Polish generateCommands.py

Story Normal Done Done sogo.mineo price Mon, 22 Jun 2020 19:58:34 +0000 Mon, 4 Jan 2021 20:23:19 +0000 Thu, 25 Jun 2020 02:28:36 +0000 0 2 <ul> <li>To pass two or more arguments to <tt>&#45;&#45;calibTypes</tt>, write <tt>&#45;&#45;calibTypes arg1 arg2 arg3 ...</tt>.</li> <li>I don't think it is good to give <tt>--force</tt> two different functions: one for script generation and another for script execution. I would suggest adding <tt>&#45;&#45;clobber-calib</tt>.</li> <li>What <tt>&#45;&#45;calib</tt> is relative to is confusing indeed. I will change it.</li> </ul> <ul> <li><tt>&#45;&#45;calib</tt> is now relative to <tt>$PWD</tt>.</li> <li>Added <tt>&#45;&#45;overwriteCalib</tt> option. With this option, <tt>ingestPsfCalibs.py</tt> will overwrite old calibs instead of raising an exception.</li> </ul> <p>Thanks for review. I added a check that <tt>calib</tt> exists, renamed <tt>outputCalibType</tt> to <tt>outputSubdir</tt>, and merged this branch to master.</p> Development Rank 0|02qps2:4i Reviewers price Sprint 2DDRP-2021 A