https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-578 DRP 2-D Pipeline <p>Following <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-565" title="Write a script to generate a bash script from yaml" class="issue-link" data-issue-key="PIPE2D-565"><del>PIPE2D-565</del></a>, bash processing scripts can be generated from YAML configuration files. Migrate the 2D DRP integration test to use this new mechanism.</p> PIPE2D-578

Migrate the integration test to use YAML config files

Task Normal Done Done sogo.mineo hassan Mon, 11 May 2020 12:49:33 +0000 Mon, 4 Jan 2021 20:23:17 +0000 Wed, 10 Jun 2020 01:43:37 +0000 0 3 <p>Is this a task to revise <tt>pfs_pipe2d/bin/pfs_integration_test.sh</tt> ?</p> <p>Yes.</p> <p>Is it essential that <tt>$DRP_STELLA_DATA_DIR</tt> falls back on <tt>"drp_stella_data"</tt> here?<br/> <a href="https://github.com/Subaru-PFS/pfs_pipe2d/blob/master/bin/pfs_integration_test.sh#L111" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/pfs_pipe2d/blob/master/bin/pfs_integration_test.sh#L111</a> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> drp_stella_data=${DRP_STELLA_DATA_DIR:-drp_stella_data} </pre> </div></div> <p>This line cannot be translated because the current <tt>generateCommands.py</tt> cannot interpret <tt>'${parameter:-word}'</tt>. If it is essential that an environment variable expansion can fall back on a constant, I have to update <tt>generateCommands.py</tt>.</p> <p>Wow, you flew through that!<br/> The only comments I have are:</p> <ul> <li>I find "integtest&#95;&#42;" a bit of an unwieldy name. I would prefer "integration&#95;test&#95;&#42;" or just "test&#95;&#42;".</li> <li>Please remove the commented-out lines in the YAML file.</li> </ul> <p>I think we also need to do the same for the weekly (in <tt>pfs&#95;pipe2d/weekly/process_weekly.sh</tt>), which may be a bit more challenging (there's more data, and it has m and n arms). Do you want to do that here, or shall we use a different ticket?</p> <p>Could we have a separate ticket for the weekly please <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=sogo.mineo" class="user-hover" rel="sogo.mineo">sogo.mineo</a>? It a big enough chunk of work and would be easier to track if it were a separate ticket.</p> <p>Thanks for review.<br/> I chose "test_calib" and "test_science" for the block names<br/> and merged this branch to master.</p> <p>As for <tt>pfs_pipe2d/weekly/process_weekly.sh</tt>, I am creating another ticket.</p> Relates PIPE2D-565 PIPE2D-566 PIPE2D-423 Development Rank 0|02qps2:1 Sprint 2DDRP-2021 A Story Points 4.0