https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-570 DRP 2-D Pipeline <p><tt>findAndTraceApertures</tt> is a C++ function with lots of branches, which makes it difficult to follow, maintain and debug. It should be replaced using a simpler algorithm, and a more modular implementation that is accessible from python.</p> PIPE2D-570

Refactor findAndTraceApertures

Story Normal Done Done price price Wed, 29 Apr 2020 15:54:34 +0000 Mon, 4 Jan 2021 20:23:16 +0000 Fri, 29 May 2020 19:37:41 +0000 0 3 <p>At the moment we're measuring the fiber profile from the data, but one could imagine generating it from the known <tt>NevenPsf</tt> and <tt>DetectorMap</tt>.</p> <p>That would be great, avoiding the need for even/odd flats, but I'm not convinced that it'd work well enough. The comparison would be very interesting, though.</p> <p>As Paul knows, we should integrate the <b>location</b> of the traces with the detector map, even if we don't measure the profiles that way</p> <p>I would love to replace <tt>FiberTrace</tt> (that essentially encodes position and profile) with a new <tt>FiberProfile</tt> object (that encodes only the profile, and use the <tt>DetectorMap</tt> for the position). However, <tt>PfsFiberTrace</tt> is part of the datamodel, so I think I need a firm proposal first, and perhaps an improved <tt>DetectorMap</tt>.</p> <p>+many. Every time we have discussed this, we have wanted to separate the trace positions from the fiber shape.</p> <p>I've never pushed back on eventually replacing Andreas' code; it's a question of priorities. We'll know more once we have lots of SCR data.<br/> Re Paul's point: I don't think we need worry about the data model (we can update it), although we do need to be careful not to break people's work flows/notebooks. I can imagine ways to providing backwards compatibility in the butler.</p> <p>This is a large addition. It doesn't change the state of the pipeline, but adds potential to change it in the future. It will be used for <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-472" title="Strategy for determining traces from non-odd/even high-density fiber data" class="issue-link" data-issue-key="PIPE2D-472"><del>PIPE2D-472</del></a>.</p> <p>Merged to master.</p> Development Rank 0|02qps1:1o Reviewers hassan Sprint 2DDRP-2021 A