https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-513 DRP 2-D Pipeline <p>install failed</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Failed test output: Global pytest output is in /home/pfs/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed The following tests failed: /home/pfs/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed 1 tests failed scons: *** [checkTestStatus] Error 1 scons: building terminated because of errors.</pre> </div></div> PIPE2D-513

drp 2d install test failed

Bug Normal Done Done price fmadec Wed, 12 Feb 2020 08:36:49 +0000 Mon, 4 Jan 2021 20:23:12 +0000 Tue, 25 Feb 2020 19:02:17 +0000 0 3 <p>When reading the PSF files, it says:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &gt; raise OSError(<span class="code-quote">'Header missing END card.'</span>) E OSError: Header missing END card. </pre> </div></div> <p>Please check that the files in drp&#95;pfs&#95;data (and in particular <tt>detectorMap&#45;2019Apr&#45;r1.fits</tt> are actual FITS files, and that <tt>git lfs</tt> has downloaded the proper content.</p> <p>right,</p> <p>it seems that drp_pfs_data is missing but I don't know why</p> <p>I made this install last November by using install_pfs.sh script</p> <p>and this time I wanted to update the drp_stella package. I tried build_pfs.sh -b master -l drp_stella but w/o sucess, so I tried build_pfs.sh -b master and gave me that error.</p> <p>is there new dependency (ie drp_pfs_data ) since last November?</p> <p>build_pfs.sh is the correct way to update one pfs package, right?</p> <p> </p> <p>The install script within pfs_pipe2d has been updated with the new dependency, and I'm guessing you have an old version. I suggest pulling pfs_pipe2d master from github.</p> <p>How should I proceed with my existing install ?</p> <p>because pfs_pipe2d is already installed , what is the proper way to update it ?</p> <p>a build_pfs.sh -l pfs_pipe2d will work ?</p> <p>or I need to git clone somewhere pfs_pipe2d , do a setup and then scons ?</p> <p>Please clone pfs_pipe2d from github and use the bin scripts there to install.</p> <p>finally I completed the install today manually.</p> <p>There was indeed an issue with drp_pfs_data, the file were not fits file. </p> <p>it was a git-lfs issue, I had to do git-lfs clone </p> <p>build_pfs script does not handle git-lfs </p> <p>I have followed the doc <a href="https://github.com/Subaru-PFS/drp_doc/blob/master/pipelineUser/installation.rst" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_doc/blob/master/pipelineUser/installation.rst</a></p> <p>git-lfs should be added as required (more clearly)</p> <p>in addition, integration_test failed on ubuntu, the git -c lfs.batch=true doesn't work.</p> <p> </p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=fmadec" class="user-hover" rel="fmadec">fmadec</a>, could you please provide details on the integration test failure? A copy of the script's output would be helpful.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=fmadec" class="user-hover" rel="fmadec">fmadec</a>: I think the problem is that you didn't do <tt>git lfs install</tt>. I've <a href="https://github.com/Subaru-PFS/drp_doc/pull/3" class="external-link" rel="nofollow">expanded the section</a> in the installation guide on installing <tt>git-lfs</tt>. Could you please have a look and verify that there is sufficient information?</p> <p>I've verified that the <tt>install_pfs.sh</tt> script works under both CentOS and Ubuntu through Docker, and the integration test is working fine for both after a few tweaks. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, could you please review those?</p> <p>Merged to master.</p> <p>The installation script worked fine for me on our local cluster.</p> Relates PIPE2D-473 Development Rank 0|02qprx:j Reviewers hassan Sprint 2DDRP-2020 A 2DDRP-2021 A