PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 [PIPE2D-505] Provide object identifiers for the sky https://pfspipe.ipmu.jp/jira/browse/PIPE2D-505 DRP 2-D Pipeline <p>Real object identifiers are required for sky data. Currently the operation</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pfsConfig.objId[pfsConfig.targetType == TargetType.SKY] </pre> </div></div> <p>returns an array of zeros.</p> <p>Please provide real identifiers for sky targets.</p> PIPE2D-505 Provide object identifiers for the sky Story Normal Done Done price hassan Fri, 20 Dec 2019 19:52:09 +0000 Mon, 4 Jan 2021 20:23:12 +0000 Mon, 23 Mar 2020 15:36:58 +0000 0 2 <p>There should be no need to auto-generate sky object Ids, as they will be provided by e.g. HSC. When we write the pfsDesign files for the simulator (or probably really the pfsConfig files, as the final choice of sky object is made by the fibre allocation software) we need to provide objIds for the sky, and those will need to be made up &#8212; in just the same way as objIds are made up for any other target.</p> <p>Now setting the <tt>objId</tt> for sky fibers in the simulator. I'm not going to bother re-running the simulator just for this (there doesn't seem an immediate need for this feature), but next time it we make a new data set, we should have non-zero <tt>objId</tt> for sky fibers.</p> <p>When will you rerun the simulator with these set correctly? I found that they weren't while trying to validate the processing, this isn't just random tidiness</p> <p>I see that you approved the pull request. How did you test it?</p> <p><a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-71" title="TargetType should be defined in datamodel.txt and headers" class="issue-link" data-issue-key="DAMD-71"><del>DAMD-71</del></a> requires updating drp&#95;stella&#95;data. How about I merge this, and then generate a new test dataset for <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-71" title="TargetType should be defined in datamodel.txt and headers" class="issue-link" data-issue-key="DAMD-71"><del>DAMD-71</del></a> with this change and the <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-71" title="TargetType should be defined in datamodel.txt and headers" class="issue-link" data-issue-key="DAMD-71"><del>DAMD-71</del></a> changes?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &gt;&gt;&gt; from pfs.datamodel <span class="code-keyword">import</span> PfsDesign, TargetType &gt;&gt;&gt; dd = PfsDesign.read(1) &gt;&gt;&gt; objId = dd.objId[dd.targetType == TargetType.SKY] &gt;&gt;&gt; objId.min(), objId.max() (61, 180) </pre> </div></div> <p>I was about to post a similar python script, using the LAM configuration. The objIds in my output were: (2,3).</p> <p>Merged to master.</p> Relates PIPE2D-492 DAMD-72 Development Rank 0|02qprx:ic Reviewers hassan Sprint 2DDRP-2021 A Story Points 2.0