<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:54:08 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-502] Correct detectormaps for spatial effects as well as wavelength effects </title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-502</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;It looks as if we&apos;re not updating the DetectorMaps&apos; fibre trace *&lt;b&gt;columns&lt;/b&gt;* in calibrateWavelength. An old RHL problem, but it may be why the vector plots are weird (or why you built them off arcs!)&lt;/p&gt;

&lt;p&gt;&lt;tt&gt;CalibrateWavelengthTask&lt;/tt&gt; updates the wavelength solution and writes a new detectormap with that correction, but changes in the &lt;em&gt;spatial&lt;/em&gt;&#160;direction are not currently determined and written to that detectormap.&lt;/p&gt;

&lt;p&gt;Update the code to provide that correction.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Side note: it may be sensible to rename the task given would correct for both wavelength and spatial directions, but this is less important.&lt;/p&gt;</description>
                <environment></environment>
        <key id="14164">PIPE2D-502</key>
            <summary>Correct detectormaps for spatial effects as well as wavelength effects </summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="hassan">hassan</reporter>
                        <labels>
                    </labels>
                <created>Fri, 20 Dec 2019 19:17:23 +0000</created>
                <updated>Mon, 4 Jan 2021 20:22:49 +0000</updated>
                            <resolved>Tue, 7 Apr 2020 19:28:57 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                            <comment id="16976" author="price" created="Thu, 2 Apr 2020 19:48:05 +0000"  >&lt;p&gt;&lt;tt&gt;CalibrateWavelengthsTask&lt;/tt&gt; calibrates the wavelengths. It does not write a new detectorMap: that is done by &lt;tt&gt;ReduceArcTask&lt;/tt&gt;. &lt;tt&gt;ReduceArcTask&lt;/tt&gt; also &lt;a href=&quot;https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceArcTask.py#L379-L396&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;updates the centers&lt;/a&gt; before writing, so I think this is already done.&lt;/p&gt;

&lt;p&gt;I propose closing this ticket.&lt;/p&gt;</comment>
                            <comment id="17007" author="price" created="Tue, 7 Apr 2020 19:28:57 +0000"  >&lt;p&gt;No objections, so closing.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="14140">PIPE2D-492</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qprx:i</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="93">2DDRP-2021 A</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>