https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-500 DRP 2-D Pipeline <p>The pfsArm.resample describes returning a pfsSpectra because pfsSpectra is the base class. However this is confusing and it may be the case that the pfsArm-&gt;pfsSpectra inheritance needs to be revised. For example, is pfsSpectra necessary?</p> PIPE2D-500

pfsArm.resample docString claims to return a pfsSpectra not pfsArm

Story Normal Done Done hassan hassan Fri, 20 Dec 2019 18:05:02 +0000 Mon, 4 Jan 2021 20:23:11 +0000 Wed, 25 Mar 2020 03:43:58 +0000 0 2 <p>It's because <tt>PfsArm.resample</tt> is defined in the base class, as <tt>PfsSpectra.resample</tt>, which can't know the type of the subclass.</p> <p><tt>PfsSpectra</tt> is necessary. Or, at least, it's very helpful to have a common base class for <tt>PfsArm</tt> and <tt>PfsMerged</tt>.</p> <p>Fixed in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-69" title="Rename pfsSpectra and pfsSpectrum" class="issue-link" data-issue-key="DAMD-69"><del>DAMD-69</del></a>.</p> Relates PIPE2D-492 Development Rank 0|02qprx:0o Sprint 2DDRP-2021 A Story Points 2.0