https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-485 DRP 2-D Pipeline <p><tt>calculate_pfsVisitHash</tt> is unused. <tt>Target.calculateVisitHash</tt> is what is used in practice for the data. We need to have some simple function (or a class method) that produces the desired value, given a list of visits, so a user can simply get the hash value.</p> <p><tt>Target.calculateVisitHash</tt> should sort the list of visits, and remove duplicates.</p> PIPE2D-485

calculate_pfsVisitHash updates

Story Normal Done Done price price Wed, 11 Dec 2019 22:33:19 +0000 Mon, 4 Jan 2021 20:23:10 +0000 Wed, 12 Feb 2020 19:01:14 +0000 0 2 <p>I think this needs to be a free function, and a glance at <tt>Target.calculateVisitHash</tt> implies that it hashes more than the visits; this isn't what the data model specifies.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> writes:</p> <blockquote> <p> I don't like the set proposal as <tt>nVisit</tt> is the number of visits, and should <tt>== len(visits)</tt>. I'd rather have the code throw on duplicates.</p></blockquote> <p>Let's also update the <tt>nVisit</tt> calculation to be the number of unique visits (so blue and red arms count as one).</p> <p>This is ready for review.</p> <p>Merged to master.</p> Relates PIPE2D-492 Development Rank 0|02qprw:0c Reviewers rhl Sprint 2DDRP-2021 A Story Points 1.0