[PIPE2D-434] ingestPfsImages.py fails when no pfsConfig is available

Relates — Mon, 10 Jun 2019 22:42:33 +0000

As reported by sogo.mineo in the #drp-2d slack channel: the above script should accept either a pfsConfig or a pfsDesign as input. In the case of the latter, it creates a new pfsConfig that is used subsequently.

However, following changes in ~~DAMD-49~~, whenever a pfsDesign is used (and there is no pfsConfig present in the input data directory), the ingestPfsImages.py script fails with an error related a non-existent 'visit' dict keyword:

$(which ingestPfsImages.py) run-002/INTEGRATION/ --mode=link run-002/drp_stella_data/raw/PFFA00000011.fits -c clobber=True register.ignore=True --pfsConfigDir=run-002/designDir/
CameraMapper INFO: Loading exposure registry from /Users/hassans/temp/IngestPfsImages-IntTest/run-002/INTEGRATION/registry.sqlite3
ingestPfs INFO: run-002/drp_stella_data/raw/PFFA00000011.fits --<link>--> /Users/hassans/temp/IngestPfsImages-IntTest/run-002/INTEGRATION/2019-03-22/PFFA000000b1.fits
Traceback (most recent call last):
  File "/Users/hassans/PFS/visualStudioCode/obs_pfs/python/lsst/obs/pfs/ingest.py", line 293, in runFile
    self.ingestPfsConfig(pfsConfigDir, hduInfoList[0], args)
  File "/Users/hassans/PFS/visualStudioCode/obs_pfs/python/lsst/obs/pfs/ingest.py", line 267, in ingestPfsConfig
    PfsConfig(**kwargs).write(dirName)
TypeError: __init__() got an unexpected keyword argument 'visit'
ingestPfs WARN: Failed to ingest file run-002/drp_stella_data/raw/PFFA00000011.fits: __init__() got an unexpected keyword argument 'visit'

In the above example, the directory run-002/designDir contains a pfsDesign file, but not a pfsConfig file.

Following ~~DAMD-49~~, the PfsConfig class now requires a 'visit0' keyword argument to be passed, not 'visit'. Please fix.

PFS-JIRA

[PIPE2D-434] ingestPfsImages.py fails when no pfsConfig is available