https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-43 DRP 2-D Pipeline <p>Currently the PFS mapper is largely copied from HSC mapper. PFS mapper should probably inherit from HSC mapper to minimize copied code</p> PIPE2D-43

clean pfsMapper.py of copied functions or make it inherit from HSC mapper

Story Major Done Done aritter aritter Thu, 21 Jul 2016 19:31:02 +0000 Mon, 10 Oct 2016 01:12:41 +0000 Mon, 10 Oct 2016 01:12:41 +0000 0 2 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a> will discuss this with Paul Price and figure out how to make further progress.</p> <p>Paul's answer to the question 'What you think would be the best way to avoid copying the functions?':</p> <p>There are a few options.<br/> 1. Subclass HscMapper.<br/> 2. Move common functionality into a class that the HscMapper and PfsMapper can both subclass from.<br/> 3. I think you can copy the methods directly.<br/> Not sure why you need to flip chips for a spectrograph.<br/> I believe there's also an effort to put some common operations into an obs_base package.</p> <p>After discussion with RHL we decided to keep the needed copied functions in pfsMapper.py at least for now.<br/> Removed un-used methods from pfsMapper.py. Kept standardizeCalib and std_... as I copied them from HscMapper. Removed static list of amplifiers which were not to be flipped from _flipChipsLR.</p> <p>See comments and obs_pfs tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-43" title="clean pfsMapper.py of copied functions or make it inherit from HSC mapper" class="issue-link" data-issue-key="PIPE2D-43"><del>PIPE2D-43</del></a></p> <p>merged into master</p> Development Rank 0|034z0b: Reviewers price Sprint 2014-16