https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-42 DRP 2-D Pipeline <p>According to the coding standards 'super' should not be used in Python classes</p> PIPE2D-42

remove "super" from python classes

Story Major Won't Fix Won't Fix price aritter Thu, 21 Jul 2016 19:28:34 +0000 Fri, 19 Oct 2018 15:46:14 +0000 Fri, 19 Oct 2018 15:46:14 +0000 0 4 <p>There are 10 occurrences:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> python/pfs/drp/stella/addDummyHeaderKeywordsTask.py: <span class="code-keyword">super</span>(AddDummyHeaderKeywordsTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/createFlatFiberTraceProfileTask.py: <span class="code-keyword">super</span>(CreateFlatFiberTraceProfileTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/extractFromProfileTask.py: <span class="code-keyword">super</span>(ExtractFromProfileTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/extractSpectraTask.py: <span class="code-keyword">super</span>(ExtractSpectraTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/findAndTraceAperturesTask.py: <span class="code-keyword">super</span>(FindAndTraceAperturesTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/getTwoDPsfPerBinTask.py: <span class="code-keyword">super</span>(GetTwoDPsfPerBinTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/readFileTask.py: <span class="code-keyword">super</span>(ReadFileTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/reduceArcRefSpecTask.py: <span class="code-keyword">super</span>(ReduceArcRefSpecTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/reduceArcTask.py: <span class="code-keyword">super</span>(ReduceArcTask, self).__init__(*args, **kwargs) python/pfs/drp/stella/traceCmdLineTask.py: <span class="code-keyword">super</span>(TraceArgumentParser, self).__init__(*args, **kwargs) </pre> </div></div> <p>Is this still desirable? LSST is starting to use <tt>super</tt> again now we have switched to python 3.</p> <p>Looking at <a href="https://developer.lsst.io/python/style.html#super-may-be-used-to-call-parent-class-methods" class="external-link" rel="nofollow">https://developer.lsst.io/python/style.html#super-may-be-used-to-call-parent-class-methods</a> (thanks to Yusra Alsayyad <span class="error">&#91;LSST&#93;</span>) indeed we can keep <tt>super</tt>. I believe PFS should align as closely as possible to the coding standards provided by LSST. </p> <p>But we should still review our code such that the <em>use</em> of <tt>super</tt> is aligned with the LSST guidelines. But this specific issue can be closed with no action.</p> <p>{{super} no longer needs to be removed with Python 3.</p> Development Rank 0|032wna: Story Points 0.25