https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-415 DRP 2-D Pipeline <p>Possibly closely connected with <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-414" title="reduceExposure.doSubtractContinuum=True does not remove continuum from all fibers" class="issue-link" data-issue-key="PIPE2D-414"><del>PIPE2D-414</del></a>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=naoki.yasuda" class="user-hover" rel="naoki.yasuda">naoki.yasuda</a> reports in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-339" title="Model arc line amplitudes" class="issue-link" data-issue-key="PIPE2D-339"><del>PIPE2D-339</del></a> that ``But for visit=14000 only a half of fibers will be identified (left hand side)``. This is probably the same problem as I report from Krypton data e.g., visit 13052, in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-411" title="reduceArc.py does not work with --config reduceExposure.doSubtractContinuum=True reduceExposure.doWriteCalexp=True" class="issue-link" data-issue-key="PIPE2D-411"><del>PIPE2D-411</del></a>. There should be 16 fibers but</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> butler_KrFeb = Butler(<span class="code-quote">"/tigress/ncaplar/ReducedData/KrFeb_2019/rerun/Apr30_2019/arc"</span>) arc = butler_KrFeb.get(<span class="code-quote">"pfsArm"</span>, visit=13052, arm=<span class="code-quote">"r"</span>, spectrograph=1) arc.wavelength[14]</pre> </div></div> <p>fails with </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">IndexError: index 14 is out of bounds <span class="code-keyword">for</span> axis 0 with size 14</pre> </div></div> <p>i.e., not all fibers have been identified. </p> <p>The full script is <tt>pfs_Apr30_Kr_Feb.sh</tt> in the folder <tt>/home/ncaplar/ReductionScripts/Apr30/</tt>.</p> <p>All outputs are in <tt>/tigress/ncaplar/ReducedData/KrFeb_2019/</tt>.</p> PIPE2D-415

Sometimes pfsArm has less elements than number of fibers in the image

Bug Normal Done Done price ncaplar Tue, 30 Apr 2019 15:09:40 +0000 Wed, 22 May 2019 12:54:47 +0000 Tue, 21 May 2019 19:37:50 +0000 0 4 <p>I have verified that the fibers that are missing in the Krypton example above are on the edge, which is consistent with what <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=naoki.yasuda" class="user-hover" rel="naoki.yasuda">naoki.yasuda</a> is reporting.</p> <p>I'm not sure my problem is the same as this. My problem happens on <tt>constructFiberTrace.py</tt> and it identifies only five fibers out of 10.</p> <p>It turns out that the reason traces aren’t being found is that some of the fibers are wider on the detector than the trace finder permits. The trace finder does a Gaussian fit of a candidate trace, and compares the derived width and center with some hard-wired values. In this case, the widths are larger than is permitted, so the candidate trace isn't accepted.</p> <p>The high limit on the Gaussian sigma is the <tt>apertureFwhm</tt> config parameter, which is <tt>2.5</tt>, but <tt>sigma ~ 2.7</tt> for the edge trace on <tt>visit=13183 arm=r</tt>. Opening up the limit allows finding all 16 traces. I’m making the limits configurable, and setting some more permissive defaults.</p> <p>This also solves <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-418" title="ConstructFiberTrace.py only identifies 5 of 10 fibers" class="issue-link" data-issue-key="PIPE2D-418"><del>PIPE2D-418</del></a>.</p> <p>Such wide traces in this data may indicate a misconfiguration of the instrument. The width of the trace varies monotonically from 2.7 on the left to 1.2 on the right, which I suspect is due to optics.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, could you please look this over?</p> <p>Changes look fine to me. Please go ahead and merge to master.</p> <p>Merged to master.</p> Duplicate PIPE2D-418 Relates PIPE2D-424 PIPE2D-414 PIPE2D-418 Development Rank 0|02qpt6:508yjoi Reviewers hassan Sprint 2DDRP-2019 E Story Points 4.0