https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-414 DRP 2-D Pipeline <p>As a concrete example, running the pipeline with <tt>reduceExposure.doSubtractContinuum=True</tt> for HgAr data taken in February, the continuum is removed from 11 out 16 fibers (see left hand side of the screenshot). This is even thought there are obviously 16 traces in the image (see right hand side of the screenshot) and psfArm has 16 inputs.</p> <p>The gist with the output from <tt>constructFiberTrace.py</tt> is at <a href="https://gist.github.com/nevencaplar/e194f448262b76b4f961fc53a5580015" class="external-link" rel="nofollow">https://gist.github.com/nevencaplar/e194f448262b76b4f961fc53a5580015</a>.</p> <p> The full script is <tt>pfs_Apr30_HgAr_Feb copy.sh</tt> in the folder <tt>/home/ncaplar/ReductionScripts/Apr30/</tt>.</p> <p> All outputs are in <tt>/tigress/ncaplar/ReducedData/HgArFeb_2019/</tt>.</p> <p>Mistakes on my part, especially in specifying design file, can not be excluded....</p> PIPE2D-414

reduceExposure.doSubtractContinuum=True does not remove continuum from all fibers

Bug Normal Done Done price ncaplar Tue, 30 Apr 2019 14:49:58 +0000 Fri, 27 Sep 2019 18:13:18 +0000 Thu, 12 Sep 2019 01:00:32 +0000 0 2 <p>Probably interesting: fiberIds are off by 1 (2 in edge case) between HgAr data and Neon/Krypton data taken in February, even though they have been taken with the same fiber configuration. Observe</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">butler_HgArFeb = Butler(<span class="code-quote">"/tigress/ncaplar/ReducedData/HgArFeb_2019/rerun/Apr30_2019/arc"</span>) arc_HgArFeb = butler_HgArFeb.get(<span class="code-quote">"pfsArm"</span>, visit=11749, arm=<span class="code-quote">"r"</span>, spectrograph=1) arc_HgArFeb.fiberId</pre> </div></div> <p>gives</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">array([619, 586, 524, 517, 463, 417, 400, 339, 307, 288, 254, 222, 191, 110, 62, 31], dtype=uint64)</pre> </div></div> <p>while </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> butler_NeonFeb = Butler(<span class="code-quote">"/tigress/ncaplar/ReducedData/NeonFeb_2019/rerun/Apr30_2019/arc"</span>) arc_NeonFeb = butler_NeonFeb.get(<span class="code-quote">"pfsArm"</span>, visit=12356, arm=<span class="code-quote">"r"</span>, spectrograph=1) arc_NeonFeb.fiberId</pre> </div></div> <p>gives</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">array([621, 587, 525, 518, 464, 418, 401, 340, 308, 289, 255, 223, 192, 111, 63, 32], dtype=uint64)</pre> </div></div> <p>I'm going to guess that this has been fixed by <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-415" title="Sometimes pfsArm has less elements than number of fibers in the image" class="issue-link" data-issue-key="PIPE2D-415"><del>PIPE2D-415</del></a>, and/or rendered unnecessary by <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-424" title="Investigate very wide traces " class="issue-link" data-issue-key="PIPE2D-424"><del>PIPE2D-424</del></a>. I propose to close it unless <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=ncaplar" class="user-hover" rel="ncaplar">ncaplar</a> objects.</p> <p>I will check this today and report back (today).</p> <p>I wanted to test this on the data taken in May, but I hit a problem described in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-427" title="reduceArc.py fails with HgAr data taken May 06, 2019" class="issue-link" data-issue-key="PIPE2D-427"><del>PIPE2D-427</del></a>.</p> <p>If I do not ingest the updated detectorMap and use the one provided in obs_pfs, the reduction passes and all 10 fibers are recognized. (I now finally understand comment in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-411" title="reduceArc.py does not work with --config reduceExposure.doSubtractContinuum=True reduceExposure.doWriteCalexp=True" class="issue-link" data-issue-key="PIPE2D-411"><del>PIPE2D-411</del></a> about ``which detectorMap to choose'''). There are some problems (subtraction seems to be a bit off, i.e., fibers seems to be systematically moved by 1 or 2 pixels; one fiber does not have full length), but I suggest closing this ticket and dealing with that after <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-358" title="DetectorMap updates should be global, not fiber-fiber" class="issue-link" data-issue-key="PIPE2D-358"><del>PIPE2D-358</del></a>. </p> <p>Closed by agreement.</p> Blocks PIPE2D-427 Relates PIPE2D-415 Development Rank 0|02qpt6:508yl03z3 Sprint 2DDRP-2019 E 2DDRP-2019 H Story Points 4.0