https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-38 DRP 2-D Pipeline <p>Currently Spectrograph and Arm are swapped in obs_pfs/python/lsst/obs/pfs/ingest.py</p> PIPE2D-38

Fix raw input name interpretation according to data model

Bug Major Done Done aritter aritter Sun, 17 Jul 2016 17:52:24 +0000 Tue, 9 Aug 2016 02:41:06 +0000 Tue, 9 Aug 2016 02:41:06 +0000 0 1 <p>Swapped 'spectrograph' and 'armNum' in obs_pfs/python/lsst/obs/pfs/ingest.py. See <a href="https://github.com/Subaru-PFS/obs_pfs/tree/tickets/PIPE2D-38" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/obs_pfs/tree/tickets/PIPE2D-38</a> </p> <p>Sorry for having a review larger than the commit...</p> <p>1. can you add `base=10` to the conversion for visit (on line 49)? It will usually have leading 0s.<br/> 2. The actual arm mapping is currently blue=1, red=2, nir=3. 0 is unused. I'll suggest med=4, and reject anything else.<br/> 3. reject spectrograph == 0<br/> 4. given that is gets used five times, please use maxCcd = 4, etc. <br/> 5. as per swinbank, are there test cases?</p> <p>I don't quite get 1. and 4. Could you please explain <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>?<br/> 2. Adopted<br/> 3. Adopted<br/> 5. I added tests in obs_pfs/tests/Mapper.py (tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-38" title="Fix raw input name interpretation according to data model" class="issue-link" data-issue-key="PIPE2D-38"><del>PIPE2D-38</del></a>)</p> <p>1. `int(S)` interprets S as an octal number if there are leading 0s. Explicitly calling `int(S, base=10)` is safer for the sequence numbers, which will be '001234' for a while.<br/> 4. The `4` (or `8`) which is used several times is always the same quantity: `maxCcds` or some name like that. Make it explicit.</p> <p>Added base=10 and maxCCDs=4. Ready for re-review...</p> <p>OK by me. Feel free to merge.</p> <p>Merged with master</p> Blocks INFRA-36 Development Rank 0|031spa: Reviewers cloomis Sprint 2014-15 2014-16