https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-37 DRP 2-D Pipeline <p>Per <a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-32" title="Scrub drp_stella for old large files" class="issue-link" data-issue-key="INFRA-32"><del>INFRA-32</del></a> review, there are a number of constants describing the geometry of the detectors in <tt>createDetGeom.py</tt> which are introduced without explanation. Please provide references as to where they have come from.</p> PIPE2D-37

Justify detector geometry constants

Bug Major Done Done aritter swinbank Fri, 15 Jul 2016 17:08:44 +0000 Fri, 30 Sep 2016 03:19:44 +0000 Fri, 30 Sep 2016 03:19:44 +0000 0 2 <p><a href="https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt</a></p> <p>Added python task to create detector geometry fits files and adopted the constants from RHL's data model (<a href="https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/blob/master/datamodel.txt</a>). Changes are in obs_pfs tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-37" title="Justify detector geometry constants" class="issue-link" data-issue-key="PIPE2D-37"><del>PIPE2D-37</del></a>.</p> <p>Per meeting of 2016-09-19 sending this to me for review.</p> <p>Several comments on GitHub: <a href="https://github.com/Subaru-PFS/obs_pfs/pull/3#pullrequestreview-723183" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/obs_pfs/pull/3#pullrequestreview-723183</a>. They're mostly quite minor, but the comments you've added about the detector geometry are quite confusing and therefore undermine the point of the ticket — please fix them up before you merge.</p> Relates INFRA-32 Development Rank 0|034xx2: Reviewers swinbank Sprint 2014-16