https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-347 DRP 2-D Pipeline <p>Provided a method that, given a fiber and wavelength, provides the appropriate <tt>Psf</tt> instance.</p> <p>This method may need to support multiple implementations.</p> PIPE2D-347

Provide a method that provides a PSF for a given fiber and wavelength

Story Normal Done Done ncaplar hassan Thu, 7 Feb 2019 21:37:36 +0000 Fri, 10 Apr 2020 13:51:37 +0000 Fri, 6 Dec 2019 19:16:02 +0000 6.0 0 4 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> Is it ok to hijack this ticket for my function which provides 2D PSF? (following the discussion and comment by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>: `Regarding the 2D PSF, I suggest that Neven provides me a function that generates his PSF, and I'll wrap it up in the API. How that gets ticketed doesn't bother me.`) Note that I would probably not provide PSF as function of wavelength as it says in the description, but x and y (which is what I believe 2D PSF class will also take).</p> <p>Yes, no problem using this ticket for your function <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=ncaplar" class="user-hover" rel="ncaplar">ncaplar</a>.</p> <p>@<a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> Paul, for the lack fo clear location, I have placed the first version of the code at <a href="https://github.com/nevencaplar/PFS_Work_In_Progress/blob/master/PIPE2D-347/Provide_PSF_2D.py" class="external-link" rel="nofollow">https://github.com/nevencaplar/PFS_Work_In_Progress/blob/master/PIPE2D-347/Provide_PSF_2D.py</a></p> <p>As you might see, it depends on the files in Tiger, which are placed at /tigress/ncaplar/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-450" title="Create array_of_arrays that contains 2d PSF model inputs" class="issue-link" data-issue-key="PIPE2D-450"><del>PIPE2D-450</del></a>.</p> <p>Very happy to help with clarification or code! Excited to see this first version implemented so that we can start working on improvements!</p> <p> </p> <p>I've got a basic implementation going; work is on <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-343" title="Define {{Psf}} class " class="issue-link" data-issue-key="PIPE2D-343"><del>PIPE2D-343</del></a>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=ncaplar" class="user-hover" rel="ncaplar">ncaplar</a>, can you regenerate your images with the PSF centered on the middle pixel? Having it centered between two pixels creates an offset when binning by 5.</p> <p>I do not fully understand the request/problem. You basically would want to an odd number of pixels in the provided PSF image? Can you problem be solved by shaving off last few columns/rows of the provided image? Would kind of offset is being created when binning by 5?</p> <p> </p> <p>It doesn't matter how many pixels there are &#8212; I can deal with the edges.</p> <p>I want the centroid of the image to be centered on a pixel after binning by 5. This cannot be done by changing the origin when binning, because 5 is an odd number. Currently, the centroid is halfway between two pixels. No matter where I place a 5x5 pixel box around that point, the centroid cannot be in the center of that box.</p> <p>Actually, maybe it would be best if I measure the centroid and interpolate so that it's centered? That way, I can remove any coordinate differences between your code and the pipeline.</p> <p>Let's not re-estimate the centroid &#8211; therein lie biases and offsets. Neven, can you generate the PSF centred in a pixel (which is 0.0, 0.0 in the coordinates we use?)</p> <p>I still do not understand the problem, and I think some more explaining will be needed on Monday. Having said that, I do not expect any problems here, I can generate either 10x oversampled PSFs or somehow shifted PSF (once when I understand what the problem is).</p> Blocks PIPE2D-326 PIPE2D-353 Relates PIPE2D-547 PIPE2D-450 PIPE2D-479 Development Epic Link PIPE2D-351 Rank 0|02qpt6:508yl0chzzy0000p929 Sprint 2DDRP-2019 J 2DDRP-2019 K Story Points 8.0