https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-344 DRP 2-D Pipeline <p>Implement arm merging in the DRP. </p> <p>If this is already implemented, provide a reference to the code under GitHub. </p> <p>Implement unit tests if not done already.</p> PIPE2D-344

Implement arm merging

Story Normal Done Done price hassan Thu, 7 Feb 2019 21:21:17 +0000 Thu, 7 Mar 2019 15:13:40 +0000 Thu, 7 Mar 2019 15:12:53 +0000 6.0 0 3 <p>I don't think we want a pointer to the code, we want the task written and documented in the user manual. We'll want a command line script that wraps it too.</p> <p>Arm merging is <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/mergeArms.py" class="external-link" rel="nofollow">implemented</a>, and it's <a href="https://github.com/Subaru-PFS/drp_doc/blob/master/pipelineUser/pipeline.rst#mergearms" class="external-link" rel="nofollow">documented</a> in the user manual. However, the algorithm is a braindead place-holder which needs to be updated with the code from the old <tt>makePfsObject</tt> function, or something even better.</p> <p>Following <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>'s comments, this issue is addressed. A separate ticket to implement an improved merging algorithm (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-385" title="Improve arm merging algorithm" class="issue-link" data-issue-key="PIPE2D-385"><del>PIPE2D-385</del></a>) has been filed. </p> Blocks PIPE2D-316 Relates PIPE2D-385 Development Epic Link PIPE2D-350 Rank 0|02qpt6:4 Sprint 2019 B Story Points 2.0