https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-340 DRP 2-D Pipeline <p>Provide a method to adjust a detector map based on small delta-x, delta-y and scale changes (small in the sense that delta-x and -y are of the order of a few pixels).</p> <p>This is useful as the slit is often adjusted when arc data are acquired by LAM, and so the detector map needs to be adjusted accordingly (compared with the summit default state) to obtain the correct wavelength solution.</p> <p>Unit tests asserting how the detector map should vary with x- y- and scale changes should be provided.</p> PIPE2D-340

Provide method to adjust detector map for arc data

Task Normal Done Done price hassan Thu, 7 Feb 2019 16:09:49 +0000 Thu, 23 May 2019 19:22:55 +0000 Thu, 7 Mar 2019 15:35:31 +0000 6.0 0 1 <p>Rotation may also be required, but that would be the subject of a separate issue.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, could you please check this is the functionality you requested?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@MacBook:~/pfs/drp_stella (tickets/PIPE2D-340 %=) $ git sub commit 7d6271f83f7168d0050e60a3e697da0a3f4ef99e Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Feb 19 15:26:06 2019 -0500 DetectorMap: remove testing Ctor I made <span class="code-keyword">this</span> Ctor <span class="code-keyword">while</span> trying to figure out problems with pybind; looks like I forgot to remove it when I was done. include/pfs/drp/stella/DetectorMap.h | 9 --------- 1 file changed, 9 deletions(-) commit b2306b211049175b44e4bc40ceaaac19a8ff3de6 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 14:11:17 2019 -0500 DetectorMap: convert DX,DY,DFOCUS to properties instead of <span class="code-keyword">enum</span> Having them as an <span class="code-keyword">enum</span> requires casting them every time we want to use them <span class="code-keyword">for</span> indexing, which is their primary purpose. Instead, as <span class="code-keyword">static</span> readonly properties, they are of the correct type <span class="code-keyword">for</span> indexing. python/pfs/drp/stella/detectorMap.cc | 11 ++++++----- tests/test_DetectorMap.py | 6 ++---- 2 files changed, 8 insertions(+), 9 deletions(-) commit d136792e6f80ac17b04b3b14139bdc4ea3040286 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 13:02:35 2019 -0500 add test <span class="code-keyword">for</span> DetectorMap slitOffsets tests/test_DetectorMap.py | 99 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) commit 18d288ba0f91ad2e6997df63b9ce69df6429eebc Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 15:05:37 2019 -0500 add SlitOffsetsConfig This allows configuring slit offsets through a Config. python/pfs/drp/stella/detectorMapContinued.py | 69 ++++++++++++++++++++++++++- tests/test_DetectorMap.py | 54 +++++++++++++++++++++ 2 files changed, 122 insertions(+), 1 deletion(-) commit 9a50145cce7b8281a5cd6bd02f962fcf5b806c0b (HEAD -&gt; tickets/PIPE2D-340, origin/tickets/PIPE2D-340) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 15:22:01 2019 -0500 constructFiberTrace: allow manual application of slitOffsets to detectorMap This allows the user to modify the slitOffsets of the detectorMap by specifying them in the config. python/pfs/drp/stella/constructFiberTraceTask.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) </pre> </div></div> <p>Merged to master.</p> Relates PIPE2D-358 PIPE2D-341 PIPE2D-319 Development Rank 0|02qpt6:3r Reviewers hassan Sprint 2019 B Story Points 5.0