https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-32 DRP 2-D Pipeline <p>Add tests for Spectrum/SpectrumSet which convince rhl that everything is working</p> PIPE2D-32

Create tests for SpectrumSet

Story Major Done Done aritter aritter Wed, 29 Jun 2016 03:39:46 +0000 Tue, 30 Aug 2016 19:30:55 +0000 Tue, 30 Aug 2016 19:30:55 +0000 0 2 <p>Added tests to compare the length of the extracted Spectrum to the height of the FiberTrace.<br/> Added tests for wavelength calibration using a previously identified reference spectrum as well as using a line list created from the simulated pixel-wavelength map. Check for monotonic wavelength solution within a certain wavelength range.</p> <p>Added tests to compare the length of the extracted Spectrum to the height of the FiberTrace.<br/> Added tests for wavelength calibration using a previously identified reference spectrum as well as using a line list created from the simulated pixel-wavelength map. Check for monotonic wavelength solution within a certain wavelength range.</p> <p>Could you please clarify exactly which commits are to be reviewed here? It looks like there's a <a href="https://github.com/Subaru-PFS/drp_stella/tree/tickets/PIPE2D-32" class="external-link" rel="nofollow"><tt>tickets/PIPE2D-32</tt> branch</a> which contains some commits which haven't been merged to master, but there's <b>also</b> evidence that some version of <a href="https://github.com/Subaru-PFS/drp_stella/commit/d2b1eee8fc4bbd696398f3ce73d4c0c1a9f231a7" class="external-link" rel="nofollow"><tt>tickets/PIPE2D-32</tt> did get merged</a> and .. I don't really know where to start. Can you explain what's happened, please?</p> <p>All commits in tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-32" title="Create tests for SpectrumSet" class="issue-link" data-issue-key="PIPE2D-32"><del>PIPE2D-32</del></a> are to be reviewed. I had to merge earlier commits to master to get the tests running for the other tickets again after removing the old testdata and creating drp_stella_data (<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-32" title="Scrub drp_stella for old large files" class="issue-link" data-issue-key="INFRA-32"><del>INFRA-32</del></a>). In hindsight these changes should probably have been made in tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/INFRA-32" title="Scrub drp_stella for old large files" class="issue-link" data-issue-key="INFRA-32"><del>INFRA-32</del></a>...</p> <p>Here's a current map of all the branches:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">* cac9b28 (HEAD -&gt; master, origin/master, origin/HEAD) Change eigen include to &lt;&gt;, remove specializations <span class="code-keyword">for</span> identify from Spectra.cc * 88f7a64 Add obs_pfs and eigen 3.2.5.lsst2 to ups/drp_stella.table * dc89384 fix includes in <span class="code-object">Math</span>.h | * 0e387d5 (origin/tickets/INFRA-32) Apply comments by reviewer | * 8cb1e8e change output path of <span class="code-quote">'createDetGeom'</span> to <span class="code-quote">'$OBS_PFS_DIR/pfs/camera/'</span> | * ef2fa55 Move createDetGeom and createRefSpec from .ipynb to .py tasks | | * 9f39051 (origin/tickets/INFRA-36) Add eigen with unsupported to list of required packages | |/ |/| * | 5da73c7 (origin/tickets/PIPE2D-34, origin/tickets/INFRA-31) Merge branch <span class="code-quote">'master'</span> into tickets/INFRA-31 |\ \ | * | 1d6e19a Change extractAllTracesFromProfile to <span class="code-keyword">return</span> a pointer to a SpectrumSet | * | d2b1eee Merge branch <span class="code-quote">'tickets/PIPE2D-32'</span> | |\ \ * | | | af2a8c8 Adopt <span class="code-keyword">final</span> comments of review * | | | 8b2e0e5 change <span class="code-quote">"ImageF(fileName)"</span>+<span class="code-quote">"makeExposure"</span> to <span class="code-quote">"ExposureF(fileName)"</span> * | | | 669b6f3 change concatenating strings with <span class="code-quote">"+"</span> to <span class="code-quote">"os.path.join"</span> * | | | d97ecd2 forgot 2 os.environ.get... * | | | 9e55292 replace <span class="code-quote">"os.eviron.get"</span> with <span class="code-quote">"lsst.utils.getPackageDir"</span> | | | | * dcfae90 (origin/tickets/PIPE2D-32, origin/tickets/INFRA-19) Clean up reduceArc..., add reduceArcTask to tests/testDRP.py | | | | * f71f51b Check RMS of identified lines | | | |/ | | |/| | | * | 28efcf2 Add tests to check <span class="code-keyword">for</span> monotonic wavelength solution | | * | 462cef7 Merge branch <span class="code-quote">'tickets/PIPE2D-26'</span> into tickets/PIPE2D-32 | | |\ \ | | | * | 5a1b8f0 (origin/tickets/PIPE2D-26) Add tests to check number of found FiberTraces and their height | |_|/ / |/| | | * | | | aa634c3 Move test data dir to drp_stella_data * | | | c4ed4b6 Fix env.Prepend to envPrepend |/ / / | * | aeb7d1e Add test to check length of Spectra (should be equal to height of FiberTraces) |/ / * | be176cb Add $PROJECT_DIR/bin to $PATH |/ * 3f1c3c8 re-add needed .ipynb files after purging all big files, add *.ipynb to .gitignore * da0c42f Merge branch <span class="code-quote">'master'</span> of github.com:Subaru-PFS/drp_stella |\ * | e2d3288 Add drp_stella_data as optional dependency |/ * b214418 Working and relatively clean commit to branch off from <span class="code-keyword">for</span> tickets </pre> </div></div> <p>Looking at that, I've gotta say I'm pretty confuse about what's supposed to go where! For comparison, here's a similar map of afw, which is a pretty complex codebase:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">* 52f1810 (HEAD -&gt; master, origin/master, origin/HEAD) Merge branch <span class="code-quote">'tickets/DM-5293'</span> |\ | * 130674c (origin/tickets/DM-5293, tickets/DM-5293) Fix test to cover both Wcs and TanWcs. |/ * 027f5db Merge pull request #78 from lsst/tickets/DM-5822 |\ | * 38e4d59 (origin/tickets/DM-5822) Fix <span class="code-keyword">for</span> optimization dependent fail of convolve.py |/ * f7cf9bf (origin/tickets/DM-1972) Merge branch <span class="code-quote">'tickets/DM-5462'</span> |\ | * c194e37 (origin/tickets/DM-5462) Minor cleanups to image py files | * bd3949c Add makeRampImage | * 8c9955e Add lsst.afw.geom.testUtils.BoxGrid | * 1e39756 Add NullLinearityType to cameraGeom |/ * a4754ad Merge pull request #77 from lsst/tickets/DM-6090 |\ | * e5f1e81 (origin/tickets/DM-6090) Replace boost::lexical_cast with std equivalent |/ * 0b3f9d4 Merge pull request #76 from lsst/tickets/DM-6089 |\ | * 9efcefc (origin/tickets/DM-6089) Replace boost fixed width integer types with std equivalents |/ * e20427c Merge pull request #75 from lsst/tickets/DM-6325 |\ | * a80364b (origin/tickets/DM-6325) Replace BOOST_STATIC_ASSERT with static_assert |/ * 7bbcb36 Merge pull request #74 from lsst/tickets/DM-6094 </pre> </div></div> <p>I hope you'll agree that's much clearer and easier to figure out which commits go with which tickets! Please, for my sanity if for no other reason, try to keep history easy to follow. <img class="emoticon" src="https://pfspipe.ipmu.jp/jira/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I <b>think</b> the work relevant for this ticket is on the following commits:</p> <ul> <li><tt>aeb7d1e</tt></li> <li><tt>28efcf2</tt></li> <li><tt>f71f51b</tt></li> <li><tt>dcfae90</tt></li> </ul> <p>While, in addition, <tt>5a1b8f0</tt> needs reviewing as part of <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-26" title="Write tests for FiberTraceSet generation" class="issue-link" data-issue-key="PIPE2D-26"><del>PIPE2D-26</del></a>.</p> <p>Please check and make sure you agree with this list before I proceed.</p> <p>Oh wow, that does look pretty confusing. Sorry about that. I promise to keep that in mind in the future. I agree with the relevant commits for this ticket, plus that 5a1b8f0 needs reviewing as part of <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-26" title="Write tests for FiberTraceSet generation" class="issue-link" data-issue-key="PIPE2D-26"><del>PIPE2D-26</del></a>.<br/> Looking at the afw commits it seems that all tickets had been reviewed and merged with master before a new ticket was started. I doubt though that we can do this all the time... To my defense, purging the large files from the drp_stella repo did brake the tests so I thought it was a good idea to merge/rebase some tickets. I believe that things like this won't happen again...</p> <p>Andreas will clean up the branches, moving the four commits above to a clean branch rebased against master, then I'll take another look at the review.</p> <p>Changes accidentally already merged into master as part of a different ticket.</p> Blocks PIPE2D-31 Development Rank 0|02qpuc:x Reviewers swinbank Sprint 2014-13 2014-14 2014-15 2014-16 Story Points 1.0