https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-31 DRP 2-D Pipeline <p>Please go over all the tests and summarise what they tell us.</p> PIPE2D-31

Produce summary of test coverage

Bug Major Done Done aritter rhl Fri, 17 Jun 2016 19:58:43 +0000 Tue, 30 Aug 2016 19:32:29 +0000 Tue, 30 Aug 2016 19:32:29 +0000 0 3 <p>There currently are unit tests for FiberTrace/FiberTraceSet and Spectrum/SpectrumSet. <br/> The testing method is the Black Box Method, meaning that the tester only knows the interface and tests the functions provided by the interface, without knowledge of what functions are called inside the tested function.<br/> Tested are: </p> <ul> <li>the constructors: - test that an objected is created</li> </ul> <ul class="alternate" type="square"> <li>test that the private variables are set according to the constructor,<br/> e.g. if one creates a FiberTrace of width 5 and height 100 pix, the <br/> image, mask, and variance arrays should be 5x100 pix, all <br/> "_is...Set" (_isTraceSet, _isProfileSet, <br/> _isFiberTraceProfileFittingControlSet) variables are false</li> </ul> <ul> <li>get/set methods: - test that we can get and set private variables using these methods,<br/> and if set the private variable is actually changed</li> <li>other methods provided by the class: - test that they do what they are supposed to do</li> <li>free functions manipulating objects (defined in the header file of the class):</li> </ul> <ul class="alternate" type="square"> <li>test that they do what they are supposed to do e.g.<br/> + PTR(FiberTraceSet&lt;ImageT, MaskT, VarianceT&gt;) math::findAndTraceApertures: </li> <li>test that the method returns a shared pointer to a FiberTraceSet containing the<br/> expected number of FiberTraces with a height within the expected limits<br/> + SpectrumSet FiberTraceSet::extractAllTracesFromProfile()</li> </ul> <p>Sets: - test "add...", "get...", "set...", "erase"</p> <p>Tests will never be complete as it would be nearly impossible to really test ALL possible input parameter combinations, but at least I am very confident that the tested functions (and functions they call) are doing the right thing. Another test is to execute the python command line tasks "reduceArc" and "reduceArcRefSpec". Both tasks find and trace the FiberTraces in a Flat, extract them, calculate the profile, "optimally" extract the spectra from an Arc, compare them to a line list, and wavelength calibrate the Arc spectra (so called "Incremental Testing"). The only difference between the 2 tasks is that one ("reduceArc") creates the line list from the wavelengths of the lines and the simulated map wavelength&lt;-&gt;pixel. The other task ("reduceArcRefSpec") uses a previously identified reference Spectrum to stretch and cross-correlate it with respect to the spectra to be identified, and creates an approximate line list from that. <br/> Tested are the butler (deliver the Flat belonging to this Arc), FindAndTraceAperturesTask (python task), CreateFlatFiberTraceProfileTask (python), ExtractSpectraTask (python), math::createLineList (C&#43;&#43;, calculates the pixel position for the line list from the simulated map pixel&lt;=&gt;wavelength), math::stretchAndCrossCorrelateSpec (C&#43;&#43;, does what it says plus creates the line list for each individual Spectrum), Spectrum.identify (C&#43;&#43;, uses the line list to identify and fit the lines, plus fit the dispersion function), write SpArm file (Python + C&#43;&#43;, still place-holders in most HDUs).</p> <p>I guess (more) discussion tomorrow...</p> <p>Darn, forgot to mention something more (had it in, cut it out to put it somewhere else, got distracted,...). For the SpectrumSet we also test that the length of the Spectrum is equal to the height of the FiberTrace, the RMS of the lines used for fitting the dispersion (I have independently confirmed that the user-defined number of randomly selected lines kept out of the fitting process deliver a similar RMS, but Spectrum currently only stores the RMS of the lines used for fitting), that the wavelength solution is monotonic, and that the wavelength range is within certain limits.</p> <p>Please transfer anything useful into the tests (no need to document things like "check the setters/getters"). Then OK to merge and close</p> <p>Nothing to merge, this was a summary of test coverage only.</p> Blocks PIPE2D-32 Development Rank 0|02qpuc: Reviewers rhl Sprint 2014-13 2014-14 2014-15 2014-16