https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-298 DRP 2-D Pipeline <p><a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-290" title="Fix normalisation of fibers in flats" class="issue-link" data-issue-key="PIPE2D-290"><del>PIPE2D-290</del></a> ("Fix normalisation of fibers in flats") corrected the fibers so they are all calibrated to the same spectrum. However, we want to apply this kind of calibration on a more frequent timescale than on which we make the flat-fields. We can measure it when we construct the <tt>FiberTrace</tt>, store it in the <tt>FiberTrace</tt>, and apply it when we extract.</p> PIPE2D-298

Record throughput in FiberTrace

Story Normal Done Done price price Thu, 18 Oct 2018 15:40:41 +0000 Mon, 5 Nov 2018 19:32:15 +0000 Mon, 5 Nov 2018 19:32:15 +0000 0 1 <p>This also involved some refactoring and the addition of a front-end to the plotting stuff I introduced earlier.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@Pauls-MacBook-Pro:~/pfs/drp_stella (tickets/PIPE2D-298=) $ git sub commit 4c46191aea4a8101caeac058a7c2c39a22199274 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Thu Oct 18 15:46:22 2018 -0400 refactor calib construction using base class The ConstructFiberFlatTask and ConstructFiberTraceTask are similar, but different. The relation has been expressed as the first inheriting from the second, but it<span class="code-quote">'s not really an '</span>is a' relationship. Instead, have them share a base <span class="code-keyword">class </span>that does the common operations. python/pfs/drp/stella/constructFiberFlatTask.py | 91 ++----------- python/pfs/drp/stella/constructFiberTraceTask.py | 163 ++++------------------ python/pfs/drp/stella/constructSpectralCalibs.py | 165 +++++++++++++++++++++++ 3 files changed, 199 insertions(+), 220 deletions(-) commit c5fa627391fbee9266137c7b572054820d2a4020 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Oct 23 17:23:16 2018 -0400 Add plotArm.py to plot spectra from a PfsArm bin.src/plotArm.py | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) commit d151e21c16cb31b93e3b78a50a83246e61c998c8 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Oct 23 17:48:00 2018 -0400 constructFiberFlat: pull averaging of spectra into base class We will use it in constructFiberTrace as well. python/pfs/drp/stella/constructFiberFlatTask.py | 16 +---------- python/pfs/drp/stella/constructSpectralCalibs.py | 34 ++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 15 deletions(-) commit 9d3442d708c9831ac37d88cbbdc5a4fe8f6663a1 (HEAD -&gt; tickets/PIPE2D-298, origin/tickets/PIPE2D-298) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Oct 23 17:50:01 2018 -0400 constructFiberTrace: scale trace to match spectra If the throughput of the fibers varies, we want the trace to track that. This is already corrected in the flat-field, but we expect that it may change on shorter durations than the imaging flat. python/pfs/drp/stella/constructFiberTraceTask.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) </pre> </div></div> <p>Merged to master after changes approved on GitHub.</p> Relates PIPE2D-290 Development Rank 0|s001d4: Reviewers hassan