https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-297 DRP 2-D Pipeline <p>The <tt>ReferenceLine</tt>, <tt>Spectrum</tt> and <tt>SpectrumSet</tt> classes are defined in the same files (same C++ header, pybind wrapper, python extension). They should be split into files named after themselves.</p> PIPE2D-297

Split ReferenceLine, Spectrum, SpectrumSet into their own files

Story Normal Done Done price price Wed, 17 Oct 2018 18:32:50 +0000 Wed, 24 Oct 2018 19:49:34 +0000 Wed, 24 Oct 2018 19:49:14 +0000 0 1 <p>Not sure it's worth reviewing this in detail, as it's just reorganisation.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@Pauls-MacBook-Pro:~/pfs/drp_stella (tickets/PIPE2D-297=) $ git sub commit c2dabbf10ddd36708ad64a0592e86fc0fafce4ce Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Oct 17 17:09:18 2018 -0400 pull ReferenceLine,Spectrum,SpectrumSet into their own files Until now, they've been mixed up in the same file. Reorganising them into their own files, named after themselves, makes them easier to find. include/pfs/drp/stella/FiberTraces.h | 2 +- include/pfs/drp/stella/ReferenceLine.h | 48 ++++ include/pfs/drp/stella/Spectra.h | 305 --------------------- include/pfs/drp/stella/Spectrum.h | 163 +++++++++++ include/pfs/drp/stella/SpectrumSet.h | 119 ++++++++ python/pfs/drp/stella/ReferenceLine.cc | 66 +++++ python/pfs/drp/stella/SConscript | 4 +- python/pfs/drp/stella/{spectra.cc =&gt; Spectrum.cc} | 89 +----- python/pfs/drp/stella/SpectrumContinued.py | 147 ++++++++++ python/pfs/drp/stella/SpectrumSet.cc | 59 ++++ ...spectraContinued.py =&gt; SpectrumSetContinued.py} | 147 +--------- python/pfs/drp/stella/__init__.py | 5 +- python/pfs/drp/stella/fiberTracesContinued.py | 2 +- python/pfs/drp/stella/tests/__init__.py | 1 + python/pfs/drp/stella/tests/base.py | 73 +++++ src/{Spectra.cc =&gt; Spectrum.cc} | 95 +------ src/SpectrumSet.cc | 92 +++++++ tests/test_ReferenceLine.py | 44 +++ tests/test_Spectrum.py | 257 +---------------- tests/test_SpectrumSet.py | 204 ++++++++++++++ 20 files changed, 1038 insertions(+), 884 deletions(-) commit b63edd1cbe642cd0287c06079b1ade503f0f7219 (HEAD -&gt; tickets/PIPE2D-297, origin/tickets/PIPE2D-297) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Oct 17 17:45:18 2018 -0400 pull FiberTrace,FiberTraceSet into their own files Until now, they have often been mixed up in the same files. Reorganising them into their own files, named after themselves, makes them easier to find. include/pfs/drp/stella/FiberTrace.h | 125 +++++++++++++++++++++ .../drp/stella/{FiberTraces.h =&gt; FiberTraceSet.h} | 123 +------------------- .../pfs/drp/stella/math/findAndTraceApertures.h | 2 +- python/pfs/drp/stella/FiberTrace.cc | 66 +++++++++++ python/pfs/drp/stella/FiberTraceContinued.py | 23 ++++ .../stella/{fiberTraces.cc =&gt; FiberTraceSet.cc} | 52 +-------- ...racesContinued.py =&gt; FiberTraceSetContinued.py} | 23 +--- python/pfs/drp/stella/SConscript | 3 +- python/pfs/drp/stella/__init__.py | 6 +- src/{FiberTraces.cc =&gt; FiberTrace.cc} | 39 +------ src/FiberTraceSet.cc | 49 ++++++++ src/math/findAndTraceApertures.cc | 1 + 12 files changed, 284 insertions(+), 228 deletions(-) </pre> </div></div> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> writes:</p> <blockquote> <p>it looks fine for me and as you say does not warrant a review. So whenever the build succeeds, merge it to master.</p></blockquote> <p>The <a href="https://travis-ci.org/Subaru-PFS/drp_stella/builds/443234763" class="external-link" rel="nofollow">build</a> passed; merged to master.</p> Development Rank 0|s001co: Reviewers hassan