https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-280 DRP 2-D Pipeline <ul> <li>Remove obs_pfs dependency on drp_stella.</li> <li>Remove <tt>datamodelIo</tt> functions.</li> <li>Purge unit tests of things that are in the integration tests.</li> <li>Review remaining drp_stella unit tests so they are useful.</li> <li>Update integration tests to run on modern example LAM data.</li> </ul> PIPE2D-280

Clean up

Story Normal Done Done price price Mon, 30 Apr 2018 22:08:11 +0000 Wed, 15 Aug 2018 21:16:52 +0000 Wed, 15 Aug 2018 21:16:52 +0000 Mon, 23 Jul 2018 00:00:00 +0900 0 2 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> requests: "During your cleanup, can you fix the <tt>run</tt> methods to accept <em>unpacked</em> data (i.e. no <tt>DataRef</tt> s)? Add <tt>runDataRef</tt> to do the unpacking".<br/> And: "We need to move all the functional code out of the <tt>CmdLineTask</tt> s. So e.g. <tt>ReduceArcTask</tt> should either not be a <tt>CmdLineTask</tt>, or it needs to defer to a "real" task. The exact level of splitting is TBD."</p> <p>All <tt>Task</tt> s should return a <tt>Struct</tt> in preference to a single value.</p> <p>Fix <tt>IdentifyLinesTask._DefaultName</tt>.</p> <p><tt>lineList</tt> should be <tt>lineListFilename</tt>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, I'm sending this to you as reviewer because the changes are so extensive (several thousands of lines) I don't know how it should be reviewed. I suggest that, rather than one person looking at every line changed, any stakeholders (including <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>) have a look at revised C++ APIs, and then someone looks over the python changes. Or we could just say that this is what we want to work off going forward, I merge and any complaints are resolved as future tickets.<br/> I've verified that the pipeline produces similar results before and after this change (I say "similar" rather than "identical" because there are some tiny algorithmic fixes to fitting rejection somewhere that had a small, apparently positive effect; there's also a change to the wavelength fitting in its own commit, but I'm not including that in the comparison).</p> <p>I haven't yet updated the integration test, but I want to get the code moving towards merge.</p> <p>For drp_stella, GitHub says "5,448 additions and 7,429 deletions."</p> <p>Ok let's see if @rhl and @cloomis at least have time this week to review. I think our outstanding unit test discussion is useful for the next time, as such tests are very useful tools to help minimize reviews by individuals. </p> <p>Merged to master after obtaining consensus on Slack.</p> Relates DAMD-30 Development Rank 0|ii04fj: Reviewers hassan