https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-28 DRP 2-D Pipeline PIPE2D-28

Convert script to use Tasks

Story Major Done Done aritter rhl Wed, 3 Sep 2014 14:34:58 +0000 Fri, 12 Aug 2016 20:00:04 +0000 Fri, 12 Aug 2016 20:00:04 +0000 0 2 <p>Probably went a bit over the top with this issue...</p> <ul> <li>Split up FiberTrace, Spectrum, and PSF into individual classes, each also getting a ...Set class</li> <li>The spatial profile of a FiberTrace is kept inside the FiberTrace class as a shared pointer to afwImage::Image&lt;float&gt;.</li> <li>1D extraction of the spectra is done by functions inside the FiberTrace class, returning one spectrum (shared pointer to a vector)</li> <li>There are 2 ways to extract a spectrum: parallel to the profile fitting (FiberTrace.MkSlitFunc(...)) or using a previously fitted profile (e.g. from the flat, FiberTrace.extractFromProfile(...)).</li> <li>If a spectrum (e.g. arc lamp) shall be extracted from a previously fitted flat profile, the procedure is to take the FiberTrace from the Flat, re-extract the FiberTrace from the arc CCD image (keeping the aperture parameters and profile), and then extract the arc spectrum to 1D. This procedure can be repeated as many times as the user wants.</li> <li>I shall eventually get rid of the 1D extraction during the profile fitting as it does exactly the same thing as the extractFromProfile(...) function.</li> <li>The control FiberTraceExtractionControl was renamed to FiberTraceProfileFittingControl as this is what it really does.</li> </ul> <ul> <li>2D PSFs can be extracted from a FiberTrace and respective 1D spectrum using the free function<br/> PTR(PSFSet&lt;ImageT, MaskT, VarianceT, WavelengthT&gt;) math::calculate2dPSFPerBin(const FiberTrace&lt;ImageT, MaskT, VarianceT&gt; &amp; fiberTrace, const Spectrum&lt;ImageT, MaskT, VarianceT, WavelengthT&gt; &amp; spectrum, const PTR(TwoDPSFControl) &amp; twoDPSFControl)</li> <li>The 1D spectrum is used to find the center of the PSF in dispersion direction.</li> </ul> <ul> <li>Tasks for 1D extraction (extractSpectraTask.py) and extraction of the 2D PSFs (getTwoDPsfPerBinTask.py) have been created.</li> <li>Tasks are still not using the butler.</li> </ul> <p>Who should review this issue? I think it is pretty much time for a code review by Paul maybe?</p> <p>The DRP tasks are now invoked by command-line tasks which execute the individual tasks.</p> <p>Work done on master</p> Blocks PIPE2D-27 Development Epic Link PIPE2D-23 Rank 0|02qpuc:zi Reviewers rhl Sprint 2014-9 2014-15 2014-16 Story Points 8.0