<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:50:30 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-278] Variance maps should accurately estimate noise in the images</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-278</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The noise in the reduced images is currently not correctly captured by the variance map.&#160;&lt;/p&gt;

&lt;p&gt;For an example, looking at the image 8603 and taking random patch of the image without sources gives variance of around 20. On the other hand, mean value in the variance image is around 36, 37. These results seem to be consistent across the whole image.&#160;&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Possible causes are 1. wrong gains, 2. given that there seems to be structure in the noise, wrong estimation of the readout, 3. other options.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="12222">PIPE2D-278</key>
            <summary>Variance maps should accurately estimate noise in the images</summary>
                <type id="1" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10503&amp;avatarType=issuetype">Bug</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="ncaplar">ncaplar</reporter>
                        <labels>
                    </labels>
                <created>Fri, 20 Apr 2018 14:01:09 +0000</created>
                <updated>Tue, 11 Sep 2018 01:39:20 +0000</updated>
                            <resolved>Tue, 11 Sep 2018 01:39:20 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="13303" author="price" created="Tue, 24 Apr 2018 19:12:41 +0000"  >&lt;p&gt;Work is being done on &lt;a href=&quot;https://jira.lsstcorp.org/browse/DM-14182&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;DM-14182&lt;/a&gt;.&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
pprice@tiger-sumire:~/LSST/ip/isr (tickets/DM-14182=) $ detrend.py /tigress/HSC/PFS/LAM/ --calib /tigress/HSC/PFS/LAM/CALIB-PAP --rerun price/pipe2d-278-fix --id visit=8603 -c isr.doEmpiricalReadNoise=True
...
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 0: 4.423752
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 1: 4.266983
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 2: 4.403465
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 3: 4.178715
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 4: 3.960904
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 5: 4.411193
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 6: 5.042430
detrend.isr INFO: Calculated empirical read noise &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; amp 7: 4.181415
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Then, in python:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&amp;gt;&amp;gt;&amp;gt; &lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; lsst.afw.image
&amp;gt;&amp;gt;&amp;gt; exposure = lsst.afw.image.ExposureF(&lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/HSC/PFS/LAM/rerun/price/pipe2d-278-fix/calExp/2017-12-15/v0008603/PFLAr1.fits&quot;&lt;/span&gt;)
&amp;gt;&amp;gt;&amp;gt; &lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; numpy as np
&amp;gt;&amp;gt;&amp;gt; np.&lt;span class=&quot;code-keyword&quot;&gt;var&lt;/span&gt;(exposure.image.array[760:2960,640:1140])
21.075794
&amp;gt;&amp;gt;&amp;gt; np.mean(exposure.variance.array[760:2000,640:1140])
19.159437
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="13304" author="price" created="Tue, 24 Apr 2018 20:11:10 +0000"  >&lt;p&gt;Should I also update the read noise in the detector? They don&apos;t seem far off, but it might be good to update them with the hardware.&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&amp;gt;&amp;gt;&amp;gt; ff = pyfits.open(&lt;span class=&quot;code-quote&quot;&gt;&quot;/home/lsst/pfs/obs_pfs/pfs/camera/r_1.fits&quot;&lt;/span&gt;)
&amp;gt;&amp;gt;&amp;gt; ff[1].data[&lt;span class=&quot;code-quote&quot;&gt;&quot;readnoise&quot;&lt;/span&gt;]
array([ 3.61,  3.78,  3.18,  2.95,  3.19,  3.8 ,  4.51,  3.18])
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="13305" author="cloomis" created="Wed, 25 Apr 2018 00:49:17 +0000"  >&lt;p&gt;Probably. With luck we will have time to figure out why the system is that much noisier in the real cryostat at LAM than in the lab dewar JHU.&lt;/p&gt;</comment>
                            <comment id="13306" author="price" created="Wed, 25 Apr 2018 15:33:14 +0000"  >&lt;p&gt;I&apos;ve updated the hard-wired read noise values. &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=ncaplar&quot; class=&quot;user-hover&quot; rel=&quot;ncaplar&quot;&gt;ncaplar&lt;/a&gt;, could you please verify this helps?&lt;/p&gt;

&lt;p&gt;The original values were:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&amp;gt;&amp;gt;&amp;gt; &lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; pyfits
&amp;gt;&amp;gt;&amp;gt; ff = pyfits.open(&lt;span class=&quot;code-quote&quot;&gt;&quot;/home/lsst/pfs/obs_pfs/pfs/camera/r_1.fits&quot;&lt;/span&gt;)
&amp;gt;&amp;gt;&amp;gt; ff[1].data[&lt;span class=&quot;code-quote&quot;&gt;&quot;readnoise&quot;&lt;/span&gt;]
array([ 3.61,  3.78,  3.18,  2.95,  3.19,  3.8 ,  4.51,  3.18])
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;They are now:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
array([ 4.423752,  4.266983,  4.403465,  4.178715,  3.960904,  4.411193,
        5.04243 ,  4.181415])
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="13757" author="ncaplar" created="Wed, 11 Jul 2018 13:18:52 +0000"  >&lt;p&gt;Just to have it here for documentation purposes, this fix did help and variance is now consistent with what we observe in the data.&lt;/p&gt;</comment>
                            <comment id="14033" author="price" created="Tue, 11 Sep 2018 01:39:20 +0000"  >&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="11100" name="Screenshot 2018-04-20 09.59.53.png" size="303747" author="ncaplar" created="Fri, 20 Apr 2018 14:00:57 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|ii04af:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ncaplar</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>