https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-277 DRP 2-D Pipeline <p>The HgAr lamp spectra that we are taking at LAM (and maybe all HgAr spectra!) have what looks like a significant continuum.</p> <p>While not important for wavelength calibrations, this matters for PSF determination.</p> <p>We think that all the spectra show this, but for definiteness:</p> <p>Neven has looked at 8603, 8604, 8605 (all in focus), are 859* are also in focus, but dithered, and for instance for defocus is 8564.</p> <p> </p> <p>The way to fix this is to do an extraction, mask the lines and fit the continuum, then use something like the self.debugInfo.residuals_frame code in reduceArcTask.py (the workhorse is ft.getReconstructed2DSpectrum(spec))</p> PIPE2D-277

Continuum subtract arc spectra in 2-d

Story Normal Done Done price rhl Thu, 19 Apr 2018 21:00:25 +0000 Thu, 3 May 2018 16:42:55 +0000 Thu, 3 May 2018 16:42:55 +0000 0 4 <p>And yes, 8937 etc. also show it, and will have the same configuration as the other 2017-12-20 reference data.</p> <p>I've got this working. The only thing I'm concerned about is that the fiber trace appears to be off horizontally (as seen by an asymmetric horizontal profile through the continuum-subtracted image), but I don't think that has anything to do with this feature.</p> <p>Based my work off <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-214" title="reduceArc should take a set of arcs and produce a pfsArm file" class="issue-link" data-issue-key="PIPE2D-214"><del>PIPE2D-214</del></a>.</p> <p>OK, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a>, I think this is ready for you. It's based on <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-214" title="reduceArc should take a set of arcs and produce a pfsArm file" class="issue-link" data-issue-key="PIPE2D-214"><del>PIPE2D-214</del></a>, so you could review all of this and kill two birds with one stone.</p> <p>Taking this back, as I've just discovered that the tests in drp_stella are not passing. These tests have not been firing under Travis because drp_stella_data was only being installed for the integration test, so was unavailable at the time drp_stella was being built.</p> <p>Merged to master without detailed review (though I did drop the commit <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> questioned). The reason for this that there's a lot of cleanup coming, and it will be easier to simply review the state of the code after the cleanup than to approve every change piecemeal.</p> Development Rank 0|02qpuc:6 Reviewers rhl