https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-276 DRP 2-D Pipeline <p>The integration test is currently broken.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> RuntimeError: Unable to retrieve dark <span class="code-keyword">for</span> {<span class="code-quote">'visit'</span>: 103, <span class="code-quote">'dateObs'</span>: <span class="code-quote">'2016-11-11'</span>, <span class="code-quote">'site'</span>: <span class="code-quote">'F'</span>, <span class="code-quote">'category'</span>: <span class="code-quote">'A'</span>, <span class="code-quote">'arm'</span>: <span class="code-quote">'r'</span>, <span class="code-quote">'spectrograph'</span>: 1}: No locations <span class="code-keyword">for</span> get: datasetType:dark dataId:DataId(initialdata={<span class="code-quote">'visit'</span>: 103, <span class="code-quote">'dateObs'</span>: <span class="code-quote">'2016-11-11'</span>, <span class="code-quote">'site'</span>: <span class="code-quote">'F'</span>, <span class="code-quote">'category'</span>: <span class="code-quote">'A'</span>, <span class="code-quote">'arm'</span>: <span class="code-quote">'r'</span>, <span class="code-quote">'spectrograph'</span>: 1}, tag=set()) </pre> </div></div> PIPE2D-276

Fix integration test

Story Normal Won't Fix Won't Fix price price Tue, 10 Apr 2018 17:26:11 +0000 Fri, 2 Nov 2018 17:47:02 +0000 Fri, 2 Nov 2018 17:47:02 +0000 0 2 <p><a href="https://travis-ci.org/Subaru-PFS/pfs_pipe2d/builds/364685890" class="external-link" rel="nofollow">https://travis-ci.org/Subaru-PFS/pfs_pipe2d/builds/364685890</a></p> <p>Cough.<br/> We should review the data used by any tests. No darks from JHU (CR-hot window), no sims before 2018-02-26; and check that none of the LAM horrors sneak in.</p> <p>This has <a href="https://travis-ci.org/Subaru-PFS/obs_pfs/builds/364723855" class="external-link" rel="nofollow">fixed Travis</a>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>, could you please sign off on this, as I've explicitly changed one of your recent changes?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@neverland:~/pfs/obs_pfs (tickets/PIPE2D-276=) $ git sub-patch commit 81534a0dc7f1737225d0332db82075918e7a04bd Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Apr 10 13:29:09 2018 -0400 config: increase number of permitted CRs Real spectrograph images are going to have many more cosmic rays than simulated images; the darks in the integration test certainly <span class="code-keyword">do</span>. Restore the nCrPixelMax back to what it was. diff --git a/config/pfs.py b/config/pfs.py index dbd9ce5..06b1349 100644 --- a/config/pfs.py +++ b/config/pfs.py @@ -26,7 +26,7 @@ <span class="code-keyword">if</span> hasattr(config, <span class="code-quote">'repair'</span>): config.repair.interp.modelPsf.defaultFwhm = 1.75 config.repair.cosmicray.cond3_fac = 4 config.repair.cosmicray.cond3_fac2 = 1 - config.repair.cosmicray.nCrPixelMax = 60000 + config.repair.cosmicray.nCrPixelMax = 5000000 config.repair.cosmicray.minSigma = 10.0 config.repair.cosmicray.min_DN = 500.0 </pre> </div></div> <p>Good. Done.<br/> But we should make sure no JHU darks leak through.</p> <p>Does not appear to be a problem any longer.</p> Development Rank 0|ii047b: