https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-25 DRP 2-D Pipeline <p>Display a flat field on ds9 and overlay a FiberTraceSet</p> PIPE2D-25

Visualise a FiberTraceSet using LSST's ds9 interface

Story Major Done Done aritter rhl Wed, 3 Sep 2014 14:28:16 +0000 Thu, 29 Sep 2016 20:59:57 +0000 Thu, 29 Sep 2016 20:59:57 +0000 0 3 <p>So far I have marked the traced center positions in DS9, but I couldn't find a function in display.ds9 to overplot a rectangular area in a DS9 image. I do have a function that reconstructs an image from the extracted spectrum and spatial profile what should fulfill the same purpose as overlaying a FiberTraceSet on a flat field...</p> <p>Created an ipython notebook in drp_stella/examples/ (tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-25" title="Visualise a FiberTraceSet using LSST&#39;s ds9 interface" class="issue-link" data-issue-key="PIPE2D-25"><del>PIPE2D-25</del></a>). Data are in drp_stella_data data/PFS/postISRCCD/2016-01-12/v0000005/PFFAr2.fits (tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-25" title="Visualise a FiberTraceSet using LSST&#39;s ds9 interface" class="issue-link" data-issue-key="PIPE2D-25"><del>PIPE2D-25</del></a>)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">import</span> lsst.afw.display as afwDisplay disp = afwDisplay.Display(1) disp.mtv(...) disp.line([(x0, y0), (x0, y0+10), (x0 + 20, y0 + 10), (x0 + 20, y0), (x0, y0)]) </pre> </div></div> <p>(note: this is the way to use ds9; please don't import <tt>lsst.afw.display.ds9</tt> directly)</p> <p>The dataID in the notebook is incorrect:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> RuntimeError: No unique lookup <span class="code-keyword">for</span> [<span class="code-quote">'taiObs'</span>, <span class="code-quote">'dateObs'</span>, <span class="code-quote">'field'</span>, <span class="code-quote">'spectrograph'</span>, <span class="code-quote">'arm'</span>] from {<span class="code-quote">'filter'</span>: <span class="code-quote">'r'</span>, <span class="code-quote">'ccd'</span>: 5, <span class="code-quote">'category'</span>: <span class="code-quote">'A'</span>, <span class="code-quote">'visit'</span>: 5, <span class="code-quote">'site'</span>: <span class="code-quote">'S'</span>}: 0 matches </pre> </div></div> <p>Using <tt>site=F</tt> works.</p> <p>Fixed the site error, sorry about that...</p> <p>The notebook appears to work, but I have some concerns that need to be addressed:</p> <ol> <li>For the loop marking the centres of the trace there appears to be an off-by-one error in x (the + signs all appear to the right of the trace). The plotting code appears to be correct, so is this a problem in your fiberTrace extraction? Please check.</li> <li>Why do you set point?</li> <li>Why is this not encapsulated in a function?</li> <li>Why did you choose to mark the centre with a set of crosses rather than drawing the ridgeline?</li> <li>You need to use <blockquote><p>with display.Buffering():</p></blockquote> <p>whenever using display writes.</p></li> </ol> <p>For markFiberTraceInMask:</p> <ol> <li>Did this have to be written in C++?</li> <li>The value of the masked image plane is hard coded to 1</li> <li>The code that sets the mask calls getArray; there is no need to go through the numpy interface</li> <li>The object passed in is a MaskedImage, not a Mask but only the Mask is modified</li> <li>The inner loop does the entire traversal <blockquote><p>maskedImage-&gt;getMask()-&gt;getArray()[ y + iY ][ x ] = 1;</p></blockquote> <p> that should be outside the loop</p></li> </ol> <p>In the notebook,</p> <ol> <li>what is <blockquote><p>display0.setMaskPlaneColor("CROSSTALK", "orange")</p></blockquote> <p>supposed to do? There is no such mask plane in the data, and it'd be unrelated to fibre traces if there was.</p></li> <li>Why do you say <blockquote><p>afwDisplay.setDefaultBackend("ds9" if True else "virtualDevice")</p></blockquote> <p>Isn't that the default it display_ds9 is setup?</p></li> </ol> <p>Also (and out of scope for this ticket but worrying)</p> <ol> <li>The routine calcMinCenMax() appears very inefficient, making copies of many ndarrays. Also, why is it a free function not part of a FiberTrace (given that when used you have to unpack the FiberTrace)</li> <li>The indentation in Math.cc is incorrect</li> <li>The lines in FiberTraces.cc exceed the permitted length of 110 characters</li> </ol> <p>Merged into master</p> Development Epic Link PIPE2D-23 Rank 0|02qpuc:r Reviewers swinbank Sprint 2014-9 2014-12 2014-13 2014-14 2014-15 2014-16 Story Points 2.0