[PIPE2D-234] typeCastNdArray should not use an extra argument to define the output type

Duplicate — Fri, 2 Nov 2018 17:38:54 +0000

Currently the function typeCastNdArray uses an unused extra parameter to define the type of the output array. Please replace this by explicit specification of the type when calling the function. Note that this will require switching the template order:

template<typename OutType, typename InType>
  ndarray::Array<OutType, 1, 1> typeCastNdArray(ndarray::Array<InType, 1, 1> const& arr);

Also provide a specialisation for <float, float> to avoid an unnecessary copy. Note that this will require a check that the input array is not used again; after this check please rename the function to ndArrayConvertArrayType (as a cast leaves the input array unmodified).

PFS-JIRA

[PIPE2D-234] typeCastNdArray should not use an extra argument to define the output type