https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-233 DRP 2-D Pipeline <p>Changing everything from double to float broke the PolyFit function. Please fix that</p> PIPE2D-233

fix PolyFit accuracy

Story Normal Done Done aritter aritter Fri, 28 Jul 2017 13:17:53 +0000 Mon, 31 Jul 2017 19:32:30 +0000 Mon, 31 Jul 2017 19:32:30 +0000 0 3 <p>I have pushed the changes to master however there are no additional tests as the plotting procedures which showed systematics in the RMS of the identified lines are in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-139" title="Add more line lists for individual lamps and a task to create one for any combination" class="issue-link" data-issue-key="PIPE2D-139"><del>PIPE2D-139</del></a>. If that's okay then the ticket is ready for review...</p> <p>We discussed this at our meeting of 2017-07-28. We agreed that the fitter <em>ought</em> to be using Chebyshevs rather than straight polynomials. Please file another ticket to fix this before merging this work.</p> <p>Minor comments on GitHub</p> Relates PIPE2D-116 Development Rank 0|ii02m7: Story Points 2.0