https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-230 DRP 2-D Pipeline <p>I discovered that there are two separate spline interpretations in drp_stella, and we should remove at least one of them. There are unnecessary copies of arrays in <tt>FiberTraces.cc</tt> that should be removed when we clean up the interpolation.</p> <p>There is functional spline interpolation in {lsst::afw::math::Interpolate}} , but it only supports <tt>std::vector&lt;double&gt;</tt>. If it is appropriate to use doubles wherever we need to interpolate in <tt>drp_stella</tt> we should definitely switch to use the <tt>afw</tt> implementation.</p> PIPE2D-230

Remove at least one of the spline implementations in drp_stella

Story Normal Done Done Unassigned rhl Sun, 23 Jul 2017 17:32:35 +0000 Fri, 2 Nov 2018 21:20:08 +0000 Fri, 2 Nov 2018 21:20:08 +0000 0 4 <p>I also note that both of these splines seem to be "natural" splines (with vanishing second derivative at the first/last knots). This is the simplest to code, but almost always a bad choice in practice.</p> <p>Per our meeting of 2017-07-28, we agreed that RHL would replace existing the spline implementations with a "not-a-knot" implementation which he has lying around. We will then file an LSST-side ticket to get the afw spline implementation cleaned up, in the hope that we can ultimately switch to that.</p> <p>I have replaced the "spline.cc" implementation with a clean implementation which supports not-a-knot; this was done on <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-228" title="Cleanup and restructure fiber assignment (&quot;ITrace&quot;) to use explicit focal plane model" class="issue-link" data-issue-key="PIPE2D-228"><del>PIPE2D-228</del></a> as the functionality was needed there (probably a mistake).</p> <p>Done already according to RHL's recent comments on this ticket.</p> <p>I don't think this ticket is done (but didn't check).  I cleaned things up, and added a not-a-knot, but I am not sure that the other versions are fine, and we certainly didn't switch to afw</p> <p>I believe there's only one spline implementation in drp_stella these days, which is RHL's.</p> <p>Agreed with RHL that this can be closed.</p> Development Rank 0|ii02jj: