https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-227 DRP 2-D Pipeline <p>Switch from FITS to yaml files to describe the PFS camera and detectors</p> PIPE2D-227

Use YamlCamera to describe PFS

Story Normal Done Done rhl rhl Sat, 22 Jul 2017 19:57:24 +0000 Thu, 27 Jul 2017 20:01:50 +0000 Thu, 27 Jul 2017 20:01:50 +0000 0 2 <p>Not all that urgent, but I'd like to switch all the obs packages to yaml. The yamlCamera support is on master obs_base so it should be in w_2017_29.</p> <p>Note that I switched the defect naming over too (it made sense to do it together as the chip names are used as keys in the yaml file)</p> <ul> <li><tt>PfsCamera</tt>: what about changing the <tt>YamlCamera</tt> so that it will load from a default (in a class variable), instead of having the subclass doing the defaulting?</li> <li><tt>camera.yaml</tt>: I'm not familiar with the higher-order features of YAML, but I think I can guess what's going on &#8212; neat! <ul> <li>The indentation is weird: 3 spaces for some, 5 for others.</li> <li>Am I right in thinking that you're faking up one large CCD with multiple individual ones? Or do you really have a single CCD with 8 amps?</li> <li>Are you only including a single optical double spectrograph because that's all we've got hardware-wise at the moment (no NIR)?</li> <li>Why are the names <tt>1r</tt> and <tt>1b</tt> within the YAML, but they're referred to as "r1" and "b1" in comments and descriptions?</li> </ul> </li> <li><tt>genDefectRegistry.py</tt> looks familiar. Has it been copied from somewhere (like obs_subaru)? If so, can we push it up to perhaps obs_base (and maybe <tt>genDefectFits.py</tt> too)?</li> </ul> <p>&gt; PfsCamera: what about changing the YamlCamera so that it will load from a default (in a class variable), instead of having the subclass doing the defaulting?</p> <p>I didn't want to do that until it becomes the accepted camera description. Maybe a mistake, but let's handle the then (I want to rename <tt>CCDs</tt> to <tt>Detectors</tt> at the same time); one motivation is that I can get a usable obs_base from w_2017_29 if I don't make this change now. I'll add a note to some suitable ticket.</p> <ul class="alternate" type="square"> <li>I'll fix the indentation;</li> <li>PFS uses a pair of 2kx4k CCDs and pretends (at the FPGA level) that it's a single 8kx8k;</li> <li>New don't have any IR detectors cold, but a pair of blue chips will be cold sometime within a month;</li> <li>I'll fix the 1r/r1 problem (it's an open issue in DAMD)</li> </ul> <p>The genDefectRegistry.py is lightly modified from obs_subaru (to deal with detector names not ccd numbers). We should open a ticket to do this properly and move to obs_base</p> <p>See <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-12" title="Change order of spectrograph and arm in data model from e.g. 1r to e.g. r1" class="issue-link" data-issue-key="DAMD-12"><del>DAMD-12</del></a></p> <p>Merged to master. You need <tt>obs_psf</tt>, <tt>datamodel</tt>, <tt>drp_stella</tt> and <tt>drp_stella_data</tt> as part of this work involved <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-12" title="Change order of spectrograph and arm in data model from e.g. 1r to e.g. r1" class="issue-link" data-issue-key="DAMD-12"><del>DAMD-12</del></a> (the 1r -&gt; r1 transition)</p> Development Rank 0|ii02iv: