https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-182 DRP 2-D Pipeline <p><tt>tests/FiberTraces.py</tt>, <tt>tests/Spectra.py</tt> and <tt>reduceArc(RefSpec)Task.py</tt> currently read the files RedFiberPixels, reference spectrum, and line list via copied code blocks. Please factor these code blocks out as individual functions and use these functions to read the files. The same for writing the pfsArm file in <tt>reduceArc(RefSpec)Task.py</tt></p> PIPE2D-182

Please factor the I/O in reduceArc(RefSpec)Task into separate functions

Story Major Done Done aritter aritter Fri, 24 Mar 2017 02:58:58 +0000 Mon, 26 Jun 2017 04:10:57 +0000 Mon, 26 Jun 2017 04:10:57 +0000 0 2 <p>Looks basically fine. Minor comments on the PR. I think it'd be nice to change <tt>readWavelengthFile</tt> to return something more idiomatic than a <tt>dict</tt>, but otherwise good to merge.</p> <p>merged into master</p> Blocks PIPE2D-139 PIPE2D-175 Development Rank 0|031vid:xi076 Reviewers swinbank Sprint 2014-17 Story Points 2.0