https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-139 DRP 2-D Pipeline <p>We need line lists for the individual lamps and a task to create a line list from these for any combination of calibration lamps and validate the input line lists.</p> <p>Per meeting of 2017-06-26, we interpret this as "create clean line lists".</p> PIPE2D-139

Add more line lists for individual lamps and a task to create one for any combination

Story Major Won't Fix Won't Fix aritter aritter Fri, 16 Dec 2016 03:25:41 +0000 Fri, 6 Oct 2017 22:26:29 +0000 Fri, 6 Oct 2017 22:26:29 +0000 0 3 <p>We discussed this at the meeting of 2017-04-14. Working on this is the primary goal for the next week; we expect <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a> to report on progress at the meeting of 2017-04-21.</p> <p>please also provide documentation, examples, and file more tickets as needed (e.g. the calibration did not fail hard enough,...)</p> <p>The method for the line list creation is as follows:</p> <ul> <li>combine the NIST line lists for the individual elements of the Arc lamps</li> <li>extract the Arc FiberTrace</li> <li>create an artificial spectrum from the NIST wavelengths and predicted strengths</li> <li>cross-correlate the Arc spectrum with the artificial spectrum to find the offset</li> <li>fit each line with a Gaussian to find the position and strength</li> <li>remove lines which have a measured strength of less than <tt>minStrength</tt>, blends, and lines which could not be fit or are flagged as problematic</li> </ul> <p>Blends are identified as follows:<br/> For each line search for lines with a fitted position close to its own position (within <tt>minDist</tt> * <tt>fwhm</tt> pixels)<br/> If a possible blend is identified, compare the predicted lines strengths.<br/> If one line is at least <tt>minRatio</tt> times stronger than the other lines in the blend, keep the strong line, otherwise discard all lines in the blend</p> <p>Split into different tickets where it makes sense:</p> <ul> <li>Please add diagnostic tools, e.g. take a pfsArm file and overplot the lines from the line lists (full and good lines only)</li> <li>keep as much information in memory as possible and return it so we can persist it later if we want to</li> <li>create an example jypiter notebook to run the task and create diagnostic plots</li> <li>if you take 2 Arcs and run the full wavelength calibration for one and apply it to the 2nd, how good is the RMS?</li> <li>plot the dispersions of adjacent/all wavelength solutions</li> <li>safe enough information to recalculate dispRMS and dispRMSCheck</li> <li>make sure that all the data read, used, mentioned, written are according to the datamodel (nm or Ang, vac or air)</li> </ul> <p>write utility functions that read back pfsArm files and plot useful information<br/> safe offset from cross correlation<br/> file DAMD PR to add 2 HDUs which will contain all the line information - 1 for NIST input, 1 for measurements</p> <p>To compile/run you will need the branches <a href="https://github.com/Subaru-PFS/obs_pfs/tree/tickets/PIPE2D-139" class="external-link" rel="nofollow">tickets/PIPE2D-139</a> for <tt>obs_pfs</tt> and <a href="https://github.com/Subaru-PFS/datamodel/tree/tickets/DAMD-17" class="external-link" rel="nofollow">tickets/DAMD-17</a> for <tt>datamodel</tt>.<br/> The example ipython notebook is in <a href="https://github.com/Subaru-PFS/drp_stella/blob/tickets/PIPE2D-139/examples/reduceArc.ipynb" class="external-link" rel="nofollow">drp_stella/examples/reduceArc.ipynb</a></p> <p>The example jupyter notebook which demonstrates how to create the master line list is examples/line lists.ipynb</p> <p>@aritter What does your constructArc.py script do? Your example passes in visit 103 and then uses 103 as the argument to reduceArc &#8211; is this a coincidence? In other words, does one run constructArc.py once and then have the ability to reduce any combination of arcs?</p> <p>I'm confused. There is no <tt>constructArc.py</tt> in <tt>examples/line lists.ipynb</tt>. <tt>constructArc.py</tt> did the ISR on the arc is - I believe - obsolete since you changed <tt>reduceArcTask.py</tt> to take the <tt>detrend}}ed {{postISR</tt> file</p> <p>Yes, you're right. Trying to do too many things.</p> <p>This had too many unrelated changes.</p> <p>We'll redo this by reading input (NIST) files for different elements; this seems to work</p> Blocks PIPE2D-138 PIPE2D-182 Relates PIPE2D-185 PIPE2D-186 PIPE2D-213 Development Rank 0|031vid:xi07d Reviewers rhl Sprint 2014-17 Story Points 8.0